Correct 2m variable names in spoc, ufo, and yaml files. - #2207
Draft
ClaraDraper-NOAA wants to merge 1 commit into
Draft
Correct 2m variable names in spoc, ufo, and yaml files.#2207ClaraDraper-NOAA wants to merge 1 commit into
ClaraDraper-NOAA wants to merge 1 commit into
Conversation
…s from airTemperature and specificHumidity to airTemperatureAt2M and specificHumidityAt2M
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JCB-GDAS station-observation configuration to align with the updated IODA/UFO convention of using 2-meter variable names (e.g., airTemperatureAt2M) for surface station obs, so configs remain consistent with upstream operator expectations.
Changes:
- Update the ADPSFC observation template to use
airTemperatureAt2Min the obs space and QC filters. - Update the ADPSFC observation chronicle station-rejection key to
airTemperatureAt2M.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| parm/jcb-gdas/observations/atmosphere/prepbufr_adpsfc.yaml.j2 | Renames surface temperature variable to airTemperatureAt2M and adjusts operator / linear-operator blocks and QC references accordingly. |
| parm/jcb-gdas/observation_chronicle/atmosphere/prepbufr_adpsfc.yaml | Renames the stations_to_reject key to match the updated variable name. |
ClaraDraper-NOAA
marked this pull request as draft
August 5, 2026 22:04
Collaborator
Author
|
Converting to draft while I update the adpupa and sfshp spoc files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For station obs, change airTemperature and specificHumidity to airTemperatureAt2M and specificHumidityAt2M.
Companion PRs
Companion PR in obsForge updates the variable name in the IODA files.
Both must be synchronously merged.
Issues
Resolves 2204
Automated CI tests to run in Global Workflow