Land update - #2182
Open
tsga wants to merge 112 commits into
Open
Conversation
Removed distribution and localization settings from the observation space configuration.
Sfc tq2m
tsga
marked this pull request as ready for review
August 3, 2026 12:07
ClaraDraper-NOAA
left a comment
ClaraDraper-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, thanks @tsga . Most comments are about naming. Pedantic, but worth trying to get right (or close to).
ClaraDraper-NOAA
previously approved these changes
Aug 5, 2026
ClaraDraper-NOAA
left a comment
ClaraDraper-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
LGTM ,thanks @tsga
jiaruidong2017
left a comment
jiaruidong2017
left a comment
Collaborator
There was a problem hiding this comment.
Great work! I just have a few minor suggestions for your consideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update jcb-gdas for doing soil DA with 3DVar and LETKF. Tested for SMAP soil moisture observation in offline land workflow.
Companion PRs
NOAA-EMC/global-workflow#5145
Issues
Resolves #2188
Refs NOAA-EMC/global-workflow/issues/5086
Automated CI tests to run in Global Workflow