Fix RP compression bug and add RFC 3597 §4 tests#702
Open
SebastiaanYN wants to merge 2 commits into
Open
Conversation
`Rp::compose_rdata` called `append_compressed_name()` which violates RFC 3597 §4: only RFC 1035 types may compress rdata names. RP is RFC 1183. Remove the `can_compress()` branch so names always compose without compression. Add compression tests covering every DNS record type whose rdata contains a domain name, and parser tests ensuring non-RFC 1035 types are still parsed when compressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rp::compose_rdatacalledappend_compressed_name()which violates RFC 3597 §4: only RFC 1035 types may compress rdata names. RP is RFC 1183. Remove thecan_compress()branch so names always compose without compression.Add compression tests covering every DNS record type whose rdata contains a domain name, and parser tests ensuring non-RFC 1035 types are still parsed when compressed.