Skip to content

Rework serials in domain::new #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
withjannisNLnetLabs wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Rework serials in domain::new #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
694db04
[new] Introduce new sequence number types
withjannisNLnetLabs Jul 7, 2026
e7ebdbb
[new] Implementation of SeqNumberU32, SoaSerial, Timestamp functional…
withjannisNLnetLabs Jul 13, 2026
29eb6b5
[new] Add testing for SeqNumberU32, SoaSerial, Timestamp functionality.
withjannisNLnetLabs Jul 13, 2026
95037df
[new] Migration of data types to new SoaSerial, Timestamp types.
withjannisNLnetLabs Jul 14, 2026
4d77fe0
PR review feedback
withjannisNLnetLabs Jul 15, 2026
67bb0d3
Self review
withjannisNLnetLabs Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/new/base/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ mod charstr;
pub use charstr::{CharStr, CharStrBuf, CharStrParseError};

mod serial;
pub use serial::Serial;
pub use serial::{SeqNumberU32, SoaSerial, Timestamp};

//--- Wire format

Expand Down Expand Up @@ -255,9 +255,6 @@ pub mod compat {
#[deprecated = "use 'crate::new::base::TTL' instead."]
pub use record::Ttl;

#[deprecated = "use 'crate::new::base::Serial' instead."]
pub use serial::Serial;

pub mod header {
#[deprecated = "use 'crate::new::base::HeaderFlags' instead."]
pub use crate::new::base::HeaderFlags as Flags;
Expand Down Expand Up @@ -355,9 +352,4 @@ pub mod compat {
#[deprecated = "use 'crate::new::base::TTL' instead."]
pub use crate::new::base::TTL as Ttl;
}

pub mod serial {
#[deprecated = "use 'crate::new::base::Serial' instead."]
pub use crate::new::base::Serial;
}
}
Loading