Skip to content

Remove zonetree use from zone status#565

Merged
tertsdiepraam merged 1 commit into
mainfrom
status-no-zonetree
Apr 7, 2026
Merged

Remove zonetree use from zone status#565
tertsdiepraam merged 1 commit into
mainfrom
status-no-zonetree

Conversation

@tertsdiepraam

@tertsdiepraam tertsdiepraam commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Moves Progress into the API crate so we can construct that directly on the server based on the state machine instead of constructing it on the client side. This meant I had to change some methods to free functions which makes the diff kind of big, but mostly that just gets rid of a level of indentation.

Getting the serial of all the zones is kind of hacked in and probably incompatible with #552, but we can probably figure something out there.

I'm keeping this slightly hacky because I'm gonna pick up refining the status next. It will then reflect the state machine more closely.


  • If you are changing Rust code or integration tests (Cargo.*, crates/, etc/, integration-tests/, src/):

    • Did you run the integration tests with act through the act-wrapper (as described in TESTING.md)?
  • If you are adding/deleting man pages:

    • Did you update the man_pages config in doc/manual/source/conf.py?
    • Did you update the packaged man pages in the Cargo.toml?
    • Did you commit the freshly built man pages?
  • If you are modifying man pages:

    • Did you commit the updated built man pages?

@tertsdiepraam
tertsdiepraam requested a review from bal-e April 2, 2026 12:15

@bal-e bal-e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The way the SOA serials are being extracted is unfortunately not compatible with #552, but @tertsdiepraam and I agreed that I'll make a small follow-up PR to this to fix things. LGTM.

@tertsdiepraam
tertsdiepraam merged commit 92285fe into main Apr 7, 2026
9 checks passed
@tertsdiepraam
tertsdiepraam deleted the status-no-zonetree branch April 7, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants