Feature/session validation#723
Open
Process-ing wants to merge 2 commits into
Open
Conversation
Process-ing
force-pushed
the
feature/session-validation
branch
from
April 22, 2026 15:49
257ac64 to
1b6c050
Compare
mariana2103
force-pushed
the
feature/session-validation
branch
from
May 14, 2026 15:55
1b6c050 to
75c2b14
Compare
mariana2103
requested changes
May 14, 2026
| }; | ||
|
|
||
| const handleCreateSession = () => { | ||
| if (!userSignedIn) { |
Collaborator
There was a problem hiding this comment.
The auth guard is only added to handleCreateSession, but handleStartSession also calls sessionsSocket.connect(), which now requires a valid token. An unauthenticated user joining via a shared link (?session=...) or the sessions list will hit the fetchSocketToken 401, fall into the .catch, and see a generic "Erro ao entrar na sessão" toast instead of being redirected to login.
Needs the same guard:
Suggested change
| if (!userSignedIn) { | |
| const handleStartSession = (sessionId) => { | |
| if (!userSignedIn) { | |
| window.location.href = backendApi.OIDC_LOGIN_URL; | |
| return; | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds some tweaks to the UI to accommodate the addition of user validation for collaborative sessions on the backend, e.g. modifying the create session button to redirect the user to the login page when not authenticated.
How to test
Follow the testing process described in the backend PR