Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@dananjohnson I know you're not super familiar with this project, but would you mind 👀 this to see if anything I'm doing here jumps out at you as a problem? I couldn't use the standard next-auth hooks to sync session across client and server for a couple of reasons:
|
Custom setup to satisfy four constraints on the auth setup: 1. ISR caching stays for the public/anonymous view. 2. Viewer data must never be cached — it's per-user. 3. Draft (auth-required) entity data must never be cached, and it's served at the same URL as the public page (no iframe/CMS container). 4. The client Relay env needs the token without a render-delay race — lazily supplying it via useSession produced null fragments and Relay errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilizes draft mode to skip cached entity data and avoid caching admin-only data without duplicating the page tree under a
/previewroute segment. This PR also updates how auth state is tracked to ensure that both client and server relay environments are in sync and aren't reliant on render-based checks via hooks.