Develop - #126
Merged
Merged
Conversation
First set of CP method code additions (does not include TVC).
python coupling tools (1/3): GeoSpec
…LCD land cover to z0m clook up table and geospec.json file
Wrf coupling python
…tric tensor terms to accomodate terrain following coordinate frame.
… the formulation of cell face velocties (for advection terms) and calculation of pressure gradient force components.
…in the moleuler diffusion term submodule.
…aing-following coordinate in sgsTKE prognostic equation and sgs Turbulence closure terms.
…ed Jacobian calculation routine
Bugfix to get the terrain following coordinate actually in place
…Cs from Bndy files.
… adding self-consistent formulations of th0 (omitting any use of pres_grnd) in surface layer schemes.
feature/fe coupling Initial phase
…ut files, also ensured strict update of master simTime to be a perfect multiple of dt (avoiding roundoff error in simTime) and implemented the ability to read/write int variables in the netcdf and binary modes of the IO module to allow for upcoming TVCP parameters.
…files feature/time_variable_in_output_files
…bmodule and added a few small code cleanup modifications.
feature/TVCP
Eloisa's block-averaged topography and some minor fixes
…ameters for WRF and FastEddy clearly separated
…the parent domain where the nest is located.
Feature/icbcs fe2fe
…device setup routine from BCs (moving into hydro_core), fix array names in Coriolis cleanup causing illegal memory access error.
…and Coriolis module/submodules and into the GRID module. Adds calculation and output of xoffSets and yOffsets for tower locations from cell-center coordinates. Fixed an issue with bad-indexing in the tower initial/static condition profile data.
…ciated with all tower coordinates in a towerSpecsFile.
…assuming lat/lon fields are provided in an initial conditions file.
… input file to convert raw binary tower data files into a single consolidated NetCDF file.
Feature/virtual towers
Reconciling 1 commit behind (docs/csv/hydro_core_surface_layer.csv)
…he first place where SimGrid.py uses an incorrect value of c1=0.0 rather than c1=1.0 when verticalDeformFactor=0.
…lean build under WITH_GAD=1.
jprestop
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist