feature!: MM clauses can access the current simulation state#309
Open
JavadocMD wants to merge 2 commits into
Open
feature!: MM clauses can access the current simulation state#309JavadocMD wants to merge 2 commits into
JavadocMD wants to merge 2 commits into
Conversation
(Slightly) breaking change due to the change in MovementClause's API. Since this is already breaking, I went ahead and eliminated SimulationTickFunction as it doesn't really make sense to add the 'available' param here. MovementClause is the only place it was used anyway, so this feels like a good code reduction.
Contributor
Author
|
Question: should we simplify the MM clause evaluate function signature by removing the star? (Making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Slightly) breaking change due to the change in MovementClause's API. Since this is already breaking, I went ahead and eliminated SimulationTickFunction as it doesn't really make sense to add the 'available' param here. MovementClause is the only place it was used anyway, so this feels like a good code reduction.