Require rubocop v0.81+ / Update rubocop configuration (#112)#7
Open
N7K4 wants to merge 46 commits into
Open
Conversation
* require rubocop v0.81~ * Add new cops
* Url-Encoding for element id (spaces and UTF-8 support) * Create Helper module and move method to helper * TestOptionError -> TestInvalidOptions * Update test_japanese_toc * Use parser.build_toc instead of Nokogiri::HTML * Use CGI.escape instead of ERB url_encode * Use url-encoded string * Remove Nokogiri::HTML * attr_accessor -> attr_reader * Add comment for auto URL encoded string * Test: parser.inject_anchors_into_html for Japanese Co-authored-by: Nicolas Karg <50399433+N7K4@users.noreply.github.com>
* Move version.rb * Require jekyll v3.8+ / nokogiri 1.10+ * Drop jekyll 3.7 support
* Add `on: pull_reqeust` * Support jekyll 3.9 * Add supprot jekyll 4.1 * Exclude Ruby 2.4 x Jekyll 4.1
* Created new configuration option to enable ordered list through use_ordered_list input * Default behaviour is false so users will continue to have ul tags * Using existing class configuration, user can change styling on top ol tag and sub listing ol tags separately * No ability to update styling on sub-nested ol tags separately but code is open to this change * Added tests for new logic * Update README with example of usage and render
* Use LF instead CRLF * Simplify list_tag method and memorize the result * Use ordered_list instead of use_ordered_list * ordered_list instead of use_ordered_list * Place ordered_list after toc_levels * Simplify list_tag
* Update rubocop
* NewCops: enable
```
Please also note that can also opt-in to new cops by default by adding this to your config:
AllCops:
NewCops: enable
```
* Add rubocop-performance
* Fix rubocop-preformance offenses
* Introduce rubocop-minitest
* Fix rubocop-minitest offenses with `rubocop -a`
* Enable github-actions dependabot and set reviewer * Use actions/setup-ruby instead of eregon/use-ruby-action
Bumps [paambaati/codeclimate-action](https://github.com/paambaati/codeclimate-action) from v2.4.0 to v2.7.4. - [Release notes](https://github.com/paambaati/codeclimate-action/releases) - [Changelog](https://github.com/paambaati/codeclimate-action/blob/master/CHANGELOG.md) - [Commits](paambaati/codeclimate-action@v2.4.0...439a9b7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove features from test_files
* Modify description
* {% toc %} tag / toc_only filter
* Move "Default Configuration" to the customization section
* Add _config.yml
* Refine English
* Add " Alternative Tools"
* Update TOC
* Update README.md
* Update TOC again
* Add "Enable TOC by default"
closes #116
* gem 'rubocop-rake' * Fix rubocop offenses * Use Ruby 2.7 for coverage/rubocop
Bumps [paambaati/codeclimate-action](https://github.com/paambaati/codeclimate-action) from v2.7.4 to v2.7.5. - [Release notes](https://github.com/paambaati/codeclimate-action/releases) - [Changelog](https://github.com/paambaati/codeclimate-action/blob/master/CHANGELOG.md) - [Commits](paambaati/codeclimate-action@v2.7.4...7bcf9e7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add to ul or ol list element an id, default is toc * Use % string * Test for list_id * doc: list_id Co-authored-by: Nicolas Karg <50399433+N7K4@users.noreply.github.com>
* Test against Jekyll 4.2 * gemfiles/jekyll_4.2.gemfile * Exclude Ruby 2.4 x Jekyll 4.2
* Use ruby/setup-ruby * Drop jekyll 3.8 * Add Ruby 3.0 * Drop Ruby 2.4 * rubocop x Ruby3 * coverage x Ruby3 * v0.17.0
* require Ruby 2.5+ * Require nokogiri 1.11 closes #142 * rubocop TargetRubyVersion: 2.5
Updates the requirements on [simplecov](https://github.com/simplecov-ruby/simplecov) to permit the latest version. - [Release notes](https://github.com/simplecov-ruby/simplecov/releases) - [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md) - [Commits](simplecov-ruby/simplecov@v0.17.1...v0.21.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
chore: Update GitHub Actions configuration
Bumps [paambaati/codeclimate-action](https://github.com/paambaati/codeclimate-action) from 2.7.5 to 3.0.0. - [Release notes](https://github.com/paambaati/codeclimate-action/releases) - [Changelog](https://github.com/paambaati/codeclimate-action/blob/master/CHANGELOG.md) - [Commits](paambaati/codeclimate-action@v2.7.5...v3.0.0) --- updated-dependencies: - dependency-name: paambaati/codeclimate-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…baati/codeclimate-action-3.0.0 Bump paambaati/codeclimate-action from 2.7.5 to 3.0.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ruby 3.2 changes Struct.new behavior so that keyword_init option is enabled by default. This means that keyword argument passed to the initializer of Struct is now treated differently with ruby3.2. To avoid behavior change in jekyll-toc test code, use hash explicitly for Struct initializer. Closes #164 .
Bumps [paambaati/codeclimate-action](https://github.com/paambaati/codeclimate-action) from 3.0.0 to 3.2.0. - [Release notes](https://github.com/paambaati/codeclimate-action/releases) - [Changelog](https://github.com/paambaati/codeclimate-action/blob/main/CHANGELOG.md) - [Commits](paambaati/codeclimate-action@v3.0.0...v3.2.0) --- updated-dependencies: - dependency-name: paambaati/codeclimate-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
test: use hash explicitly for Struct initializer for ruby 3.2
``` $ bundle exec rubocop -a ```
Test against Ruby 3.2
Updates the requirements on [simplecov](https://github.com/simplecov-ruby/simplecov) to permit the latest version. - [Release notes](https://github.com/simplecov-ruby/simplecov/releases) - [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md) - [Commits](simplecov-ruby/simplecov@v0.21.2...v0.22.0) --- updated-dependencies: - dependency-name: simplecov dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Drop Ruby 2.5 support / CI against Jekyll 4.3 / Refactoring `gemspec` file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require rubocop v0.81~
Add new cops