refactor: remove @embedFile, switch to fetch-first workflow - #34
Merged
Conversation
Remove the two-stage build pipeline (compile_tool + @embedfile) and the embedded PDBx fallback. The binary now always resolves a dictionary from --dict, $MMCIF_DICT_PATH, or the config cache, erroring with a helpful message if none is found.
Remove src/compile_tool.zig (build-time .dic-to-.mdict converter) and data/mmcif_pdbx.dic (~5.6 MB bundled dictionary source), both made redundant by the removal of @embedfile in the previous commit.
- Handle access() errors explicitly instead of silent discard (main.zig) - Update CI step name to remove stale "embedded" reference - Add [Unreleased] CHANGELOG section documenting removal - Fix stale "PDBj JSON" description in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.zigmain.zigto 3-tier (--dict → env → cache → error)src/compile_tool.ziganddata/mmcif_pdbx.dic(5.6 MB)tests/fixtures/minimal.dicfor compile round-trip testingResults
build.zig: single-stage (was three-stage)Run 'mmcif-dict fetch' to downloadCloses #33
Test plan
zig buildsucceedszig build -Doptimize=ReleaseFastsucceedszig build testpassescompileround-trip with test fixture worksmmcif-dict fetch+ query round-trip (requires network)