This repository was archived by the owner on Apr 29, 2021. It is now read-only.
hard lstm ds1 onnx export#37
Open
julianmack wants to merge 44 commits into
Open
Conversation
Hard LSTM working but not exporting Profiling running for CPU
hard lstm performance improvements and run profile notebook Added second profiling notebook Added third implementation Added Layers to hardlstm2 Added layers to hard lstm
…'t share parameters
samgd
suggested changes
Mar 17, 2020
samgd
left a comment
samgd
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Comments should generally describe why, not what, but otherwise is fine pending hard_lstm PR to go in :-)
Co-Authored-By: Sam Davis <samgd@users.noreply.github.com>
Co-Authored-By: Sam Davis <samgd@users.noreply.github.com>
julianmack
force-pushed
the
script_update
branch
from
770e248 to
f9ddccf
Compare
julianmack
force-pushed
the
script_update
branch
from
6d8b9b1 to
784767d
Compare
julianmack
force-pushed
the
script_update
branch
from
ed6b16d to
8b4e1dd
Compare
Contributor
Author
|
Responded to comments (and fixed merge conflicts) - ready to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to enable onnx export of ds1 with hard LSTM.
This must go in after #34. (edit: #34 is now in)