Features/many optimizations#306
Open
LuckyScamper wants to merge 11 commits into
Open
Conversation
LuckyScamper
commented
Feb 25, 2021
LuckyScamper
commented
Contributor
- Textureregionatlas.load will no longer throw an exception, but merely look if the file follows a XML tag route and then goes along with that. Improves performance and the if-statement works in our use case.
- Combobox: removes thrown exception if the widget turns out to be null. Mostly happens in Myrapad
- Localization now works in Myra; one needs to set Project.Localize with a lambda/function to determine how to localize in their project, and use L18nTextKey in xmmp to determine the key.
- MMLDiagnosticAction (Credit goes to techpizza) handles errors and tells the user where issues start happening.
- Newer version of Framework.Portable in use
- ColorHSV now uses equals/gethashcode (mostly auto-generated) because C# prefers it that way when you use != and == operators. It also improves performance slightly
Feature/xmmp events
…nto TechnologicalPizza-master
…ion when you can check if something is xml?
multiple bugfixes
Also includes a few code optimizations for sake of readability and removing warnings.
Small edit in Widget for sake of readability.
Contributor
|
cool stuff :) |
|
Will this be merged ? |
rds1983
force-pushed
the
master
branch
3 times, most recently
from
a105205 to
3c691c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.