Skip to content

Refactor PPC CPU feature detection#912

Open
brad0 wants to merge 1 commit into
Multicorewareinc:masterfrom
brad0:power_cpu
Open

Refactor PPC CPU feature detection#912
brad0 wants to merge 1 commit into
Multicorewareinc:masterfrom
brad0:power_cpu

Conversation

@brad0

@brad0 brad0 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@brad0

brad0 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

cc @kirithika7

@kirithika7 kirithika7 requested a review from mcw-Lavanya July 2, 2026 04:37
@mcw-Lavanya

Copy link
Copy Markdown
Collaborator

Hi @brad0
The code quality check is failing with a style issue (trailing whitespace) in source/common/ppc/cpu.h (line 4). Please remove the trailing whitespace, rebase/update the PR, and push the changes so that the code quality check passes.

The patch looks good to me.

Thank you.

@brad0

brad0 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

There is a comment at the top I need answered first and then I can update the patch.

@mcw-Lavanya

Copy link
Copy Markdown
Collaborator

I am not sure what to put for Authors for such a simple refactoring.

Will let you know ASAP.

@mcw-Lavanya

Copy link
Copy Markdown
Collaborator

Hi @brad0,
Kindly add yourself as the author for cpu.h file and update the patch so that we can merge it.
Thank you

@brad0

brad0 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. Will do so.

@brad0

brad0 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@mcw-Lavanya Completed.

@mcw-Lavanya mcw-Lavanya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and acknowledging!
The code looks good

@brad0

brad0 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

cc @kirithika7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants