Skip to content

[BB PR #37] pkgconfig: Make all libs public if static build #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ponsanthini wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BB PR #37] pkgconfig: Make all libs public if static build #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .migration-bb-pr-37.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Migrated from Bitbucket PR #37

**Title:** pkgconfig: Make all libs public if static build
**Author:** Rob Hall
**State:** OPEN
**Created:** 2025-08-19
**Original PR:** https://bitbucket.org/multicoreware/x265_git/pull-requests/37
**Original Diff:** https://api.bitbucket.org/2.0/repositories/multicoreware/x265_git/diff/robxnano/x265_git:9a78de495eb1%0Dcfee9638c82b?from_pullrequest_id=37&topic=true

## Description

If x265 is built as a static library, an application which tries to build with it using pkg-config may fail to link correctly as the pc file lists its required libraries in Libraries.private. The application has no way of knowing that it needs to link against these libraries, so the build fails. To fix this, the required libraries should be listed in the public Libraries section if a static build is requested. This is the same approach as used by ffmpeg, x264, and all Meson projects which use the built-in pc file generator.