✨ Quality: Create multi-stage Dockerfile for building and serving the application#169
Open
lukebaze wants to merge 1 commit intoMrXujiang:masterfrom
Conversation
…application The existing Dockerfile needs to be replaced with a proper multi-stage build that handles both the frontend build process and production serving. This will reduce image size and improve security by separating build and runtime environments. Affected files: Dockerfile Signed-off-by: 0xKermini <67284748+lukebaze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing Dockerfile needs to be replaced with a proper multi-stage build that handles both the frontend build process and production serving. This will reduce image size and improve security by separating build and runtime environments.
Severity:
highFile:
DockerfileSolution
Create a multi-stage Dockerfile with: Stage 1 (builder) using Node.js 16-alpine to install dependencies and build the frontend with Umi.js; Stage 2 (production) using Node.js 16-alpine to serve the built application. Include proper environment variables for NODE_ENV, PORT configuration. Add health check endpoint. Copy server.js and dist folder from builder stage. Expose port 3000. Set proper working directory and user permissions for security.
Changes
Dockerfile(modified)Testing
Closes #162