Skip re-upload of unchanged metadata artifacts on publish - #13
Open
Moustafa-Moustafa wants to merge 1 commit into
Open
Skip re-upload of unchanged metadata artifacts on publish#13Moustafa-Moustafa wants to merge 1 commit into
Moustafa-Moustafa wants to merge 1 commit into
Conversation
Moustafa-Moustafa
force-pushed
the
fix/skip-artifact-reupload-on-publish
branch
2 times, most recently
from
February 24, 2026 14:37
9a5c3b4 to
123dae0
Compare
PublishedMetadata.create_from_file() unconditionally saved artifacts to storage on every publish. When a publication was created for an already-published repository version, this overwrote identical metadata blobs with new timestamps, causing problems with CDN caching layers that use last-modified times. Applied the same deduplication pattern used for content artifact uploads: look up the artifact by checksum first, verify the file exists in storage, and skip the write if it does. Assisted-by: GitHub Copilot closes pulp#7344
Moustafa-Moustafa
force-pushed
the
fix/skip-artifact-reupload-on-publish
branch
from
March 11, 2026 19:50
123dae0 to
46c4cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PublishedMetadata.create_from_file() unconditionally saved artifacts to storage on every publish. When a publication was created for an already-published repository version, this overwrote identical metadata blobs with new timestamps, causing problems with CDN caching layers that use last-modified times.
Applied the same deduplication pattern used for content artifact uploads: look up the artifact by checksum first, verify the file exists in storage, and skip the write if it does.
closes pulp#7344
📜 Checklist
See: Pull Request Walkthrough