Fix/telemetry overlapping flushes#411
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details:
Serialized Flush Operations: Chained concurrent calls to flush() onto the activeFlushPromise sequence using a clean promise-chain wrapper, guaranteeing that only one send operation remains in flight at any given time.
Preserved Queue Integrity: Spliced batches are correctly prepended back to eventQueue if the send operation completely fails after all retry attempts (and the sink remains enabled), preventing duplicate or lost events.
Reset Handling: Added safety guarantees that automatically discard failed batches and prevent event prepending if resetSink() is invoked during active flushes.
Unit Tests: Added three comprehensive concurrent flush test cases to cover:
Overlapping flush serialization.
Queue integrity and event ordering preservation when flushes fail.
Sink reset/disable behaviors during failed concurrent flushes.
Closes #338