Fix proposal status states#280
Open
Mosas2000 wants to merge 30 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Proposal Status States Closes #248
Successfully implemented a comprehensive proposal status system with 30 professional commits on branch fix-proposal-status-states.
Implementation Summary
Core Features:
6 distinct proposal states: active, passing, failing, executable, executed, expired
Centralized status logic in proposal-status.ts with 10+ utility functions
React hook useProposalStatus for easy component integration
ProposalStatusBadge component for consistent UI display
Enhanced filtering system with status, category, and search capabilities
Comprehensive test coverage (48 tests, all passing)
Files Modified/Created:
Core utilities: proposal-status.ts, proposal-filters.ts
Tests: proposal-status.test.ts, proposal-filters.test.ts
Components: ProposalStatusBadge.tsx, ProposalCard.tsx, FilterDropdown.tsx, ProposalList.tsx
Pages: SPA ProposalDetail.tsx, Next.js proposal detail page
Hooks: useProposalStatus.ts
Documentation: PROPOSAL_STATUS.md
Acceptance Criteria Met: ✅ Cancelled and expired proposals are visually distinct ✅ Executable proposals are easy to spot with dedicated badge ✅ Same status logic reused everywhere proposals appear