fix data and add checks

.github/workflows/validate-brand-yaml.yml

@@ -0,0 +1,47 @@
+name: Validate Brand YAML
+
+on:
+  pull_request:
+    branches:
+      - master
+    types:
+      - opened
+      - synchronize
+      - reopened
+    paths:
+      - 'data/brands/**'
+      - 'data/mapping.json'
+      - 'validate_brand_yaml.py'
+
+jobs:
+  validate-brand-yaml:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
+
+      - name: Install dependencies
+        run: pip install pyyaml
+
+      - name: Validate changed brand YAML files
+        run: |
+          BASE_SHA="${{ github.event.pull_request.base.sha }}"
+          mapfile -t files < <(
+            git diff --name-only --diff-filter=ACMR "$BASE_SHA" HEAD -- 'data/brands/**/*.yaml'
+          )
+
+          if ((${#files[@]} == 0)); then
+            echo "No brand YAML files added or modified in this PR."
+            exit 0
+          fi
+
+          printf 'Validating %s changed file(s):\n' "${#files[@]}"
+          printf '  %s\n' "${files[@]}"
+          python validate_brand_yaml.py "${files[@]}"

data/brands/arturia/matrixbrute.yaml

@@ -39,7 +39,7 @@ cc:
   max: 127
   min: 0
   name: 'VCO1: Ultrasaw'
-  value: 668
+  value: 68
 - description: ''
   max: 127
   min: 0

data/brands/chasebliss/cxm1978.yaml

@@ -113,7 +113,7 @@ cc:
     min: 0
     max: 127
   - name: AUX PERF SWITCH 3
-    value: 230
+    value: 30
     description: "Any value will trigger this event"
     type: System
     min: 0

data/brands/disasterarea/dpc8ezgen2.yaml

@@ -123,4 +123,4 @@ cc:
     type: null
     value: 122
 pc:
-  - description: Loads Presets 0 - 127
+  description: Loads Presets 0 - 127

data/brands/disasterarea/dpcmicro.yaml

@@ -25,3 +25,4 @@ cc:
     max: 127
 
 pc:
+  description: ''

data/brands/drscientist/dusk.yaml

@@ -2,11 +2,10 @@ midi_channel:
   instructions: |+
 
 pc:
-  - description: |+
-      PC# 0 = Bypass
-      PC# 1 – 4 = Internal Preset # 1 – 4
-      PC# 5 – 99 = Presets saved with MIDI CC #55
-
+  description: |+
+    PC# 0 = Bypass
+    PC# 1 – 4 = Internal Preset # 1 – 4
+    PC# 5 – 99 = Presets saved with MIDI CC #55
 
 cc:
   - name: Remote Tap

data/brands/electroharmonix/pog3.yaml

@@ -1,5 +1,7 @@
 brand: Electro-Harmonix
 model: POG3 Polyphonic Octave Generator
+midi_channel:
+  instructions: ''
 pc:
   description: |+
     PC Messages 1 to 100: Loads the preset associated with the MIDI PC number

data/brands/emcustom/amiuniversaldualtrs.yaml

@@ -1,6 +1,10 @@
 brand: EM Custom
 model: AMI Universal Dual TRS
 url: 'https://emcustom.eu/downloads/AMI_MI.pdf'
+midi_channel:
+  instructions: ''
+pc:
+  description: ''
 data:
   - name: Tip 1 Off
     value: '80'

data/brands/g-lab/bc1.yaml

@@ -19,79 +19,79 @@ pc:
 cc: 
   - name: COMP OFF
     value: 108
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 0
     max: 63
   - name: COMP ON
     value: 108
-    description: [Description of function]
+    description: ''
     type: Parameter
     min: 64
     max: 127
   - name: SELECT COMP A
     value: 109
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 0
     max: 63
   - name: SELECT COMP B
     value: 109
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 64
     max: 127
   - name: SELECT COMP A
     value: 110
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 1
     max: 1
   - name: SELECT COMP B
     value: 110
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 2
     max: 2
   - name: SELECT COMP C
     value: 110
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 3
     max: 3
   - name: BYPASS ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 1
     max: 1
   - name: BUFFER ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 2
     max: 2
   - name: COMP A ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 3
     max: 3
   - name: COMP B ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 4
     max: 4
   - name: COMP C ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 5
     max: 5
   - name: SEL COMP ON
     value: 111
-    description: [Description of function]
+    description: ''
     type: Parameter 
     min: 6
     max: 6

data/brands/kinotone/ribbons.yaml

@@ -1,5 +1,9 @@
 brand: Kinotone
 device_name: Ribbons
+midi_channel:
+  instructions: ''
+pc:
+  description: ''
 cc:
   - name: High Pass Filter
     value: 0

data/brands/moog/matriarch.yaml

@@ -565,7 +565,7 @@ cc:
       Default 8192 = 50% / no swing
     type: System
     min: 0
-    max: 16383
+    max: 127
   - name: Sequence Keyboard Control
     value: 24
     description: |
@@ -845,7 +845,7 @@ cc:
       Default 0 / Off
     type: System
     min: 0
-    max: 400
+    max: 127
   - name: KB CV OUT Range
     value: 59
     description: |
@@ -949,7 +949,7 @@ cc:
       Default 16383
     type: System
     min: 0
-    max: 16383
+    max: 127
   - name: Arp/Seq Random Repeats
     value: 72
     description: >

data/brands/novation/ultranova.yaml

@@ -349,7 +349,7 @@ cc:
   max: 127
   min: 0
   name: AmpEnv Decay
-  value: 775
+  value: 75
 - description: ''
   max: 127
   min: 0

data/brands/onecontrol/midisolostereoloop.yaml

@@ -14,12 +14,12 @@ pc:
 phantom_power: unknown
 midi_mapping: not applicable
 cc:
-  - name: off
+  - name: 'off'
     value: '102'
     description: 'disengage loop'
     min: 0
     max: 63
-  - name: on
+  - name: 'on'
     value: '102'
     description: 'engage loop'
     min: 64

data/brands/roland/fr-18d.yaml

@@ -1,5 +1,9 @@
 brand: 'Roland'
 model: FR-18d
+midi_channel:
+  instructions: ''
+pc:
+  description: ''
 data:
   - name: Bank Select LSB
     value: 0

data/brands/singular_sound/aeros_looper.yaml

@@ -420,6 +420,7 @@ cc:
     type: system
     value: 43
   - description: Cancel Stop Stops the song at the end of the longest loop in the current song part
+    max: 4
     min: 4
     name: Stop End of Loop
     type: system

data/brands/sourceaudio/collider.yaml

@@ -326,13 +326,13 @@ cc:
     max: 5
   - name: Preset Decrement
     value: 80
-    description: [Description of function]
+    description: ''
     type: System
     min: 0
     max: 127
   - name: Preset Increment
     value: 82
-    description: [Description of function]
+    description: ''
     type: System
     min: 0
     max: 127
@@ -368,7 +368,7 @@ cc:
     max: 127
   - name: Toggle Delay (A) Bypass/Engage
     value: 102
-    description: [Description of function]
+    description: ''
     type: System
     min: 0
     max: 127
@@ -386,7 +386,7 @@ cc:
     max: 127
   - name: Toggle Reverb (B) Bypass/Engage
     value: 104
-    description: [Description of function]
+    description: ''
     type: System
     min: 0
     max: 127

data/brands/synergyamps/syn20ir.yaml

@@ -4,11 +4,12 @@ midi_thru: No
 phantom_power: Yes
 midi_clock: No
 
-midi_channel: |+
-  Out of the box, the SYN-20IR is set up to receive MIDI program changes on MIDI channel OMNI.
-  You can change the MIDI channel using the free Synergy editor software.
+midi_channel:
+  instructions: |+
+    Out of the box, the SYN-20IR is set up to receive MIDI program changes on MIDI channel OMNI.
+    You can change the MIDI channel using the free Synergy editor software.
 
-  Values and descriptions are based on the official Synergy Amps documentation (SYNERGY-SYN-20IR-MANUAL-FINAL-2-13-2025)
+    Values and descriptions are based on the official Synergy Amps documentation (SYNERGY-SYN-20IR-MANUAL-FINAL-2-13-2025)
 
 pc: 
   description: |+