v1.4.19: Logo redesign and Hanken Grotesk typeface#318
Conversation
- A1: fallback picks largest-fitting INSTALLED natural-language model (recommend_model_id is catalog-wide and would error "Model not installed") - A2: per-GPU (index,total,free) helper; feed pinned GPU's free VRAM into the offload gate so pin and gate cannot disagree; note worker-0 contention - C3: "wait for that GPU" = server-queue on the pinned worker, no fallback - C4: role already exposed via _auth/status/userRole, drop backend change - touchpoints: A1/A2 also touch prompt_assistant/mod.rs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares the project for the v1.4.19 release by adding the design specifications, implementation plan, and brand assets—including a new logo and the self-hosted Hanken Grotesk typeface. Feedback on the implementation plan points out that running nvidia-smi directly via std::process::Command on Windows will cause a flashing console window, and recommends using the project's existing std_command_no_window helper to prevent this regression.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| pub fn detect_gpu_vram() -> Vec<(u32, u64, u64)> { | ||
| let output = std::process::Command::new("nvidia-smi") | ||
| .args([ | ||
| "--query-gpu=index,memory.total,memory.free", | ||
| "--format=csv,noheader,nounits", | ||
| ]) | ||
| .output(); |
There was a problem hiding this comment.
Using std::process::Command::new("nvidia-smi") directly on Windows will cause a flashing console window to briefly appear every time the command is executed. To prevent this regression (which was previously fixed in v0.9.0), please use the project's custom helper crate::comfyui::process::std_command_no_window("nvidia-smi") instead.
| pub fn detect_gpu_vram() -> Vec<(u32, u64, u64)> { | |
| let output = std::process::Command::new("nvidia-smi") | |
| .args([ | |
| "--query-gpu=index,memory.total,memory.free", | |
| "--format=csv,noheader,nounits", | |
| ]) | |
| .output(); | |
| pub fn detect_gpu_vram() -> Vec<(u32, u64, u64)> { | |
| let output = crate::comfyui::process::std_command_no_window("nvidia-smi") | |
| .args([ | |
| "--query-gpu=index,memory.total,memory.free", | |
| "--format=csv,noheader,nounits", | |
| ]) | |
| .output(); |
1 participant
v1.4.19: Logo redesign and Hanken Grotesk typeface
Implements the design-language updates from the latest Claude Design handoff: a redesigned brand mark and a new typeface. No functional/code-logic changes.
Brand and design refresh
src/lib/assets/logo.png+ newlogo.svgvector source), the favicon, and the full Tauri desktop/installer, iOS, and Android icon sets (src-tauri/icons/**).public/fonts/, declaredfont-weight: 100 900, so it loads offline and satisfies the production CSP (font-src 'self'), with the system stack as fallback. No CSP edit needed (same-origin/fonts/).Also included
docs/plans/*1.4.19*.md). Docs-only, no code impact.Version
package.json,src-tauri/Cargo.toml,src-tauri/tauri.conf.json(+Cargo.lock). Changelog prepended toRELEASE_NOTES.mdandCHANGELOG.md.Validation
cargo check: passnpm run build: pass (fonts + favicon emitted todist/, CSS references both woff2 subsets)Bot/branch triage