Skip to content

fix: add catch fallback to getRandomItems API query on home page load #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadicalMuffinMan merged 2 commits into from
Jul 15, 2026
Merged

fix: add catch fallback to getRandomItems API query on home page load #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ac544
fix: add catch fallback to getRandomItems API query on home page load
mattsigal Jul 15, 2026
98a36f2
fix: resolve rowNode.contains is not a function TypeError on blur in …
mattsigal Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/app/src/components/MediaRow/ModernMediaRow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const ModernMediaRow = ({
const keyPrefix = rowId || title || rowIndex || '';

useEffect(() => {
const el = rowElementRef.current;
const el = document.querySelector(`[data-row-index="${rowIndex}"]`) || rowElementRef.current;
registerRowRef?.(rowIndex, el);
return () => registerRowRef?.(rowIndex, null);
}, [rowIndex, registerRowRef]);
Expand Down Expand Up @@ -100,10 +100,10 @@ const ModernMediaRow = ({

const handleBlur = useCallback((e) => {
const nextTarget = e.relatedTarget;
const rowNode = rowElementRef.current;
if (rowNode && nextTarget && rowNode.contains(nextTarget)) return;
const rowNode = document.querySelector(`[data-row-index="${rowIndex}"]`) || rowElementRef.current;
if (rowNode && nextTarget && typeof rowNode.contains === 'function' && rowNode.contains(nextTarget)) return;
setFocusedItemId(null);
}, []);
}, [rowIndex]);

const handleFocusedChange = useCallback((itemId) => {
setFocusedItemId(itemId || null);
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/views/Browse/Browse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ const Browse = ({
api.getResumeItems(),
api.getNextUp(),
api.getUserConfiguration().catch(() => null),
api.getRandomItems(settings.featuredContentType, settings.featuredItemCount),
api.getRandomItems(settings.featuredContentType, settings.featuredItemCount).catch(() => null),
settings.mergeContinueWatchingNextUp ? api.getItems({
IncludeItemTypes: 'Episode',
Filters: 'IsPlayed',
Expand Down
Loading