Skip to content

pressing bool settings changes it instantly - #166

Open
harleykradovill wants to merge 1 commit into
Moonfin-Client:masterfrom
harleykradovill:boolsettings
Open

pressing bool settings changes it instantly#166
harleykradovill wants to merge 1 commit into
Moonfin-Client:masterfrom
harleykradovill:boolsettings

Conversation

@harleykradovill

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

This PR changes the action of pressing on a boolean setting in settings, so it instantly changes instead of showing the boolSetting group. This matches the core apps where pressing a boolean/toggle setting instantly changes the setting.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Selecting a boolean setting now directly calls boolSettingChanged().
  • boolSettingChanged() now accepts the setting object as a param, reads the current value, and toggles it (true <-> false). It keeps the setting specific triggers for global.rememberme and seerr.blockNsfw.
  • Removed the now unused boolSetting RadioButtonList from the xml and references to it in the brightscript file.

Testing

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant