Skip to content

feat-settingsync - Allow for Custom Home Rows Sync across devices#946

Open
mattsigal wants to merge 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/fix-custom-external-rows-sync
Open

feat-settingsync - Allow for Custom Home Rows Sync across devices#946
mattsigal wants to merge 1 commit into
Moonfin-Client:mainfrom
mattsigal:feature/fix-custom-external-rows-sync

Conversation

@mattsigal

@mattsigal mattsigal commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Fixes issues preventing fully custom home rows (e.g. Letterboxd activity, custom IMDb/TMDB lists created via the Custom Home Rows Wizard) from syncing, authenticating on new installs, and propagating across device profiles.

Related Issues

Link related issues or tickets separated by commas.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • Fixed 401 Unauthorized responses from /Moonfin/CustomRows/Items on new installs by replacing raw Authorization header with buildServerAuthorizationHeader in CustomExternalListsService.
  • Normalized serverId to 'custom' across fromJson() deserialization and stableId getter in HomeSectionConfig.
  • Updated _applyServerSettingsUnbatched() in PluginSyncService to preserve pre-existing custom dynamic sections (enabled: false) when applying incoming server profiles.

Platform

  • Android
  • iOS
  • tvOS
  • Web
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Created a Custom Home Row (Letterboxd user list "Matt's Activity") on Windows Desktop.
  2. Verified item fetching authenticated with 200 OK on /Moonfin/CustomRows/Items.
  3. Launched clean Android TV Beta client on Nvidia Shield TV Pro (192.168.0.224).
  4. Confirmed "Matt's Activity" appeared under "Saved Custom Home Rows" in the Custom Home Rows Wizard.
  5. Toggled "Matt's Activity" to ON on the Shield and verified items rendered cleanly on the Android TV homepage.

Screenshots (if applicable)

Include screenshots or recordings for UI changes.

Adding a Custom Home Row in Windows Desktop:
2026-07-26_08-13-01_moonfin

Available in Home Sections:
2026-07-26_08-14-20_moonfin

Custom Home Row on Windows Desktop:
2026-07-26_08-13-18_moonfin

Synced to Android TV (TV profile, so pulled in disabled):
Shield_Screenshot_2026-07-26_08-49-08

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant