fix(sync) - Prevent home row toggles from re-enabling during profile sync#936
Open
mattsigal wants to merge 2 commits into
Open
fix(sync) - Prevent home row toggles from re-enabling during profile sync#936mattsigal wants to merge 2 commits into
mattsigal wants to merge 2 commits into
Conversation
…sync Fix feedback loop where omitted server built-in sections were re-created as enabled: true by _appendDisabledBuiltinSections due to reading default true boolean preferences. - Append missing built-in home sections as enabled: false in _appendDisabledBuiltinSections and explicitly update their toggle preferences. - Add missing sinceYouWatched1..5 mappings to _rowEnabledPreference.
mattsigal
force-pushed
the
bugfix/home-row-toggles-sync-pairing
branch
from
July 26, 2026 14:28
d8b2792 to
360c9eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fixes an issue where home row toggles for "Rewatch", "Since You Watched", Seerr lists, IMDb lists, TMDB lists, and Radarr/Sonarr Calendars automatically re-enabled themselves after profile synchronization or app restarts, causing me to think I was losing my mind.
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
_appendDisabledBuiltinSectionsin plugin_sync_service.dart so built-in sections omitted from server profile layouts append asenabled: falseand explicitly update their corresponding toggle preferences tofalse.sinceYouWatched1Enabled..sinceYouWatched5Enabledmappings to_rowEnabledPreferencein plugin_sync_service.dart._syncSeerrHomeRowsWithSectionsin plugin_sync_service.dart to synchronizeSeerrPreferences.homeRowsConfigin lockstep withhomeSectionsConfigwhenever server profile sections are applied or reset._homeRowsConfigFromSections()andisSeerrHomeRowEnabled()in seerr_preferences.dart to default unconfigured or omitted Seerr row sections toenabled: falseinstead of falling back toenabled: true.Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist