bugfix-playback - Add opaque black backdrop to remove artifacts#931
Merged
RadicalMuffinMan merged 1 commit intoJul 26, 2026
Merged
Conversation
Add a Positioned.fill(child: ColoredBox(color: Colors.black)) at index 0 of VideoPlayerScreen's root Stack. This prevents underlying route bleed-through along letterbox borders for non-standard aspect ratio videos (e.g., 1920x804 / 2.39:1) and eliminates background UI ghosting when modal dialogs are open during playback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Well, it happened again. Was watching a movie and the nefarious phantom UI elements were bleeding through the top and the bottom of the image. Decided to do some tests and found that adding a background route bleed-through along letterbox borders for non-standard aspect ratio videos fully eliminates the background UI ghosting when modal dialogs are open during playback!
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
Positioned.fill(child: ColoredBox(color: Colors.black))widget at position 0 of the rootStackinVideoPlayerScreen(right behind_buildVideoSurface()).ItemDetailScreen) from bleeding through along top/bottom letterbox bars on videos with non-traditional aspect ratios (e.g. 1920x804 / 2.39:1).Playback Information, track selectors) are open over the video player.Platform
Testing
Describe how this change was tested.
Test Steps
Playback Informationdialog during playback and verified no background text/UI ghosts through behind the modal.Screenshots (if applicable)
Include screenshots or recordings for UI changes.
The Bug Is Back (pinkish lines above and below the video frame)
The Bug Is Defeated (solid black above and below the video frame)
Checklist