bugfix-ci - Fix PR builds from failing for MacOS#930
Merged
RadicalMuffinMan merged 2 commits intoJul 26, 2026
Conversation
On GitHub Actions PR builds from forks/branches, secrets are not present, triggering an unsigned build. Passing CODE_SIGNING_REQUIRED=NO to xcodebuild causes CocoaPods framework scripts to skip ad-hoc signing bundled pod frameworks (e.g., Avfilter.framework). Xcode's subsequent CodeSign phase fails with exit code 65 due to unsigned subcomponents. Removing this flag ensures CocoaPods ad-hoc signs all embedded pod frameworks before app signing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fixes macOS build step failures on GitHub Actions PR runs by removing
CODE_SIGNING_REQUIRED=NOfrom the unsigned archive command.Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
build-macos.shto removeCODE_SIGNING_REQUIRED=NOfromARCHIVE_CMDwhen building unsigned (UNSIGNED=1).CODE_SIGNING_REQUIRED=NOcaused CocoaPods' framework script (Pods-Runner-frameworks.sh) to skip ad-hoc signing bundled pod frameworks (Avfilter.framework, etc.).CODE_SIGNING_REQUIRED=NOallows CocoaPods to ad-hoc sign (-) embedded pod frameworks so Xcode's finalCodeSignstep onMoonfin.appsucceeds cleanly.Platform
Testing
Describe how this change was tested.
Test Steps
Command CodeSign failed with a nonzero exit codefailure onAvfilter.framework.CODE_SIGNING_REQUIRED.Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist