Skip to content

adjust sidebar gradient based on opacity setting#775

Open
jmawet wants to merge 1 commit into
Moonfin-Client:mainfrom
jmawet:navbar-gradient
Open

adjust sidebar gradient based on opacity setting#775
jmawet wants to merge 1 commit into
Moonfin-Client:mainfrom
jmawet:navbar-gradient

Conversation

@jmawet

@jmawet jmawet commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Radical Muffin Man, you and I have been compromising for too long. We should both be happy.

It's become clear to me that you like more gradient on your sidebar, whereas I prefer a solid sidebar. To compromise, you pushed the gradient out so most of the sidebar would follow the opacity, and then the edge would drop off in a gradient.

My new proposal is this: let the opacity define the gradient. 100% opacity? No gradient. 90%? Slight gradient at the edge. 50%? Complete gradient. 0%? Completely transparent (below 50 is not even currently supported on core tv/desktop, it stops at 50%)

This way I could set 100% and have a solid sidebar, and you could do 50 or 75% and have more of a gradient that you like.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • Adjust gradient calculation for sidebar

Platform

  • Android TV
  • iOS
  • tvOS
  • Web
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Tested on desktop and TV

Screenshots (if applicable)

Include screenshots or recordings for UI changes.
Screenshot_20260711_151141
Screenshot_20260711_151058
Screenshot_20260711_151046
Screenshot_20260711_151025
Screenshot_20260711_151004
20260711_151805
20260711_151828

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant