feat: request an offline license from the browser activation flow - #20
Open
TobbenTM wants to merge 1 commit into
Open
feat: request an offline license from the browser activation flow#20TobbenTM wants to merge 1 commit into
TobbenTM wants to merge 1 commit into
Conversation
The backend now accepts a `method` query parameter on the activation-request endpoint, so a normal browser activation can mint an offline license instead of an online one. `request_activation` gains an optional `activation_method` argument, defaulting to online. The parameter is added to the request URL only, never to `client_query`, which is shared with /validate and /revoke where the backend does not accept it. The response carries only id/request/browser, so the client stamps the requested method onto the new `activation_request::method` field. Everything downstream was already correct: `get_requested_activation` does not inspect the method, `validate_token_online` short-circuits offline licenses and `revoke_activation` refuses them. The JUCE bridge exposes the same argument on `beginActivation`, plus a `pendingActivationMethod()` accessor so a UI can label the wait. The moonbase_licensing JUCE module is deliberately unchanged; its mirrored headers are re-synced because CI gates on them.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend now accepts a
methodquery parameter on the activation-request endpoint, sorequest_activationgains an optionalactivation_methodargument (defaulting to online) that lets a normal browser activation mint an offline license instead.The parameter is added to the request URL only, never to
client_query, which is shared with/validateand/revokewhere the backend does not accept it; since the response carries onlyid/request/browser, the client stamps the requested method onto a newactivation_request::methodfield. Everything downstream was already correct:get_requested_activationdoes not inspect the method,validate_token_onlineshort-circuits offline licenses andrevoke_activationrefuses them.The JUCE bridge exposes the same argument on
beginActivation, plus apendingActivationMethod()accessor so a UI can label the wait. Themoonbase_licensingJUCE module is deliberately unchanged (its mirrored headers are re-synced only because CI gates on them), and the defaulted argument keeps all existing call sites source-compatible in this header-only library.Verified with the core suite (111/111, including 5 new cases covering the offline request URL, the "product does not allow offline activations" 400 mapping, an end-to-end request/poll/no-revalidation/not-revocable flow, and guards that
method=does not leak into/validateor/revoke) and the JUCE module suite (50/50, unchanged).