Full API Coverage, Bug Fixes & Infrastructure Improvements#24
Merged
Conversation
node_modules was committed by initial contributors. Removed from git index via git rm -r --cached. The .gitignore already has node_modules/ listed so it will not be re-added. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the library from partial API coverage to full parity with the Monnify API specification.
New modules
Six new service modules have been added: Invoice, Settlement, Wallet, LimitProfile, DirectDebit, and BillsPayment (including the complete bill payment lifecycle — validate customer, vend, and requery).
New methods on existing modules
Ten new methods across
Transaction,ReservedAccount,Disbursement, andVerification, includinggetAllTransactions,verifyNin,resendBulkTransferOTP, and four new reserved account update methods.Bug fixes
Verificationmethods were throwing aReferenceErrorat runtime due to an undefined schema importcardTokenizationwas using the wrong validator schemagetBulkTransferStatuswas pointing to the wrong endpointcreateMandateschema has been rewritten to match the Monnify spec — the previous implementation used field names that do not exist in the API (mandateType,debitType,frequency,beneficiary*,payer*). All calls to this method must be updated to use the correct spec fields (customerName,customerEmailAddress,customerPhoneNumber,customerAddress,customerAccountNumber,customerAccountBankCode). SeeCHANGELOG.mdfor the full before/after field mappingdebitMandate—amounthas been renamed todebitAmountandcustomerEmailis now a required field, both corrected to match the specInfrastructure
SANDBOX_Cache.js) with a safe in-memory cache — no more accidental secret commitsnode_modulesuntracked from version controlactions/checkout@v6andactions/setup-node@v6c8with Codecov integrationexpress,swagger-jsdoc, andswagger-ui-expressmoved todevDependencies>=18— Node 16 reached end-of-life in September 2023. Node 24 added to CI matrixTests
Grows from ~30 tests across 7 files to 71 tests across 11 files, all passing against the Monnify sandbox.
See
CHANGELOG.mdfor the full detailed breakdown.