Run playwright auto bump daily#51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rotunda logic relies on monkeypatching Playwright. We have unit tests and integration tests to ensure these are still valid, but those are only valuable if we actually run them against the latest Playwright versions.
This PR will run a script each day that checks for the latest published Playwright version. If the new version is above our pinned version, it will put up a PR against main that will kick off a full build and run our integration tests. If they pass as-is we should be able to simply merge it to support the latest version of Playwright. If it fails that indicates we need to likely update some portion of the patch.