Refactor: move resolveCaseIdent to GeneratorHelpers, eliminating duplication across generators

[Copilot]

resolveCaseIdent (which qualifies DU case identifiers when RequireQualifiedAccess is present) was duplicated — once as a named function in CreateDUModule and once as inline logic in LensesGenerator. This consolidates it into GeneratorHelpers.

Changes

• GeneratorHelpers.fs: Add resolveCaseIdent (requiresQualifiedAccess: bool) (parent: LongIdent) (id: Ident) : SynLongIdent helper
• DUCasesGenerator.fs: Remove local resolveCaseIdent from CreateDUModule; update two call sites to GeneratorHelpers.resolveCaseIdent
• LensesGenerator.fs: Replace inline matchCaseIdentParts + SynLongIdent.Create with GeneratorHelpers.resolveCaseIdent

// Before — DUCasesGenerator.fs (local copy)
let resolveCaseIdent (requiresQualifiedAccess: bool) (parent: LongIdent) (id: Ident) : SynLongIdent = ...

// Before — LensesGenerator.fs (inline)
let matchCaseIdentParts =
    if requiresQualifiedAccess then (parent |> List.map _.idText) @ [id.idText]
    else [id.idText]
let fullCaseName = SynLongIdent.Create matchCaseIdentParts

// After — both sites
let fullCaseName = GeneratorHelpers.resolveCaseIdent requiresQualifiedAccess parent id

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Repo Assist] Monthly Activity 2026-03</issue_title>
<issue_description>🤖 Repo Assist here — I'm an automated AI assistant for this repository.

Activity for March 2026

Suggested Actions for Maintainer

Comprehensive list of all pending actions requiring maintainer attention:

• Review PR [Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes #249 #250: Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes Duplicate Code: Type-filtering pattern repeated 5 times in Ast.fs #249 — Review
• Review PR [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245: Refactor: move resolveCaseIdent to GeneratorHelpers — closes Duplicate Code: resolveCaseIdent Logic Duplicated Across DUCasesGenerator and LensesGenerator #244, Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248, Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator #251 — Review
• Review PR [Repo Assist] Refactor: extract generateModules helper to eliminate Generate boilerplate #241: Extract generateModules helper — eliminates remaining Generate boilerplate — closes Duplicate Code: Generate Method Structure in DUCasesGenerator and FieldsGenerator #240, Duplicate Code: Structural Duplication in Generate Methods of DUCasesGenerator and FieldsGenerator #242, Duplicate Code: Structural Duplication in Generate Method Across DUCasesGenerator and FieldsGenerator #246, relates to Duplicate Code: Namespace-filtered Type Extraction Pattern in FieldsGenerator and DUCasesGenerator #221 — Review
• Review PR [Repo Assist] chore: update Expecto 10.2.1 → 10.2.3 #243: Update Expecto 10.2.1 → 10.2.3 (patch, no breaking changes) — Review
• Review/close PR [docs] Update documentation for infrastructure fixes from 2026-03-04 #239: [docs] Update documentation for infrastructure fixes from 2026-03-04 — Review
• Fix version issue FYI: released version is 0.85, not 0.8.5 #247: NuGet package published as 0.85.0 instead of 0.8.5 — tag v0.85 should have been v0.8.5; consider deprecating 0.85.0 and republishing as 0.8.5 — View
• Close issues Duplicate Code: Type-filtering pattern repeated 5 times in Ast.fs #249, Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248, Duplicate Code: Structural Duplication in Generate Method Across DUCasesGenerator and FieldsGenerator #246, Duplicate Code: resolveCaseIdent Logic Duplicated Across DUCasesGenerator and LensesGenerator #244, Duplicate Code: Structural Duplication in Generate Methods of DUCasesGenerator and FieldsGenerator #242, Duplicate Code: Generate Method Structure in DUCasesGenerator and FieldsGenerator #240: Addressed by PRs [Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes #249 #250 and [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245 and [Repo Assist] Refactor: extract generateModules helper to eliminate Generate boilerplate #241 respectively — close once PRs are merged
• Review issue Duplicate Code: Namespace-filtered Type Extraction Pattern in FieldsGenerator and DUCasesGenerator #221: Namespace-filtered type extraction pattern — largely addressed by merged PRs [Repo Assist] Extract parseInputAst and filterByAttribute helpers to GeneratorHelpers #232, [Repo Assist] Extract createCaseMatchClause helper in DUCasesGenerator #230, and pending PRs [Repo Assist] Refactor: extract generateModules helper to eliminate Generate boilerplate #241 and [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245 — consider closing — View

Future Work for Repo Assist

• Task 4 follow-up: Larger dependency updates pending investigation: FSharp.Core 9.0.101 → 10.0.103 and FSharp.Compiler.Service 43.9.101 → 43.10.103 (require .NET 10 SDK migration); Tomlyn 0.18 → 1.0.0 (major bump, API compatibility check needed).
• Task 6 (stale PR nudges): PRs [Repo Assist] Refactor: extract generateModules helper to eliminate Generate boilerplate #241, [Repo Assist] chore: update Expecto 10.2.1 → 10.2.3 #243, [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245, [Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes #249 #250 are less than 14 days old. Re-check each run.
• Task 9 (new contributors): No new human contributors detected this month; re-check each run.
• Version fix: If maintainer re-publishes 0.8.5, update CHANGELOG.md note and close issue FYI: released version is 0.85, not 0.8.5 #247.

Run History

2026-03-11 10:06 UTC — Run

• 💬 Commented on Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator #251: noted it's a duplicate of Duplicate Code: resolveCaseIdent Logic Duplicated Across DUCasesGenerator and LensesGenerator #244 and Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248, pointed to PR [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245 which already addresses the issue
• 🏷️ Labelled Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator #251 with duplicate
• 📋 Tasks run: Task 1 (triage Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator #251), Task 7 (label Duplicate Code: Qualified DU Case Name Resolution in LensesGenerator and DUCasesGenerator #251), Task 11 (monthly activity)

2026-03-10 10:07 UTC — Run

• 🔧 Created PR [Repo Assist] Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes #249 #250: Refactor: extract filterTypes helper to eliminate 5-fold duplication in Ast.fs — closes Duplicate Code: Type-filtering pattern repeated 5 times in Ast.fs #249
• 💬 Commented on Duplicate Code: Type-filtering pattern repeated 5 times in Ast.fs #249: linked to new PR with fix description
• 📋 Tasks run: Task 2 (fix issue Duplicate Code: Type-filtering pattern repeated 5 times in Ast.fs #249), Task 11 (monthly activity)

2026-03-09 10:11 UTC — Run

• 💬 Commented on FYI: released version is 0.85, not 0.8.5 #247: explained v0.85 tag caused 0.85.0 package instead of 0.8.5; suggested maintainer deprecate and republish
• 🏷️ Labelled FYI: released version is 0.85, not 0.8.5 #247 with bug
• 💬 Commented on Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248: pointed to PR [Repo Assist] Refactor: move resolveCaseIdent to GeneratorHelpers — closes #244 #245 which already addresses the duplication
• 🏷️ Labelled Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248 with enhancement, refactor
• 📋 Tasks run: Task 1 (triage FYI: released version is 0.85, not 0.8.5 #247, Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248), Task 7 (label FYI: released version is 0.85, not 0.8.5 #247, Duplicate Code: Qualified Case Identifier Resolution in DUCasesGenerator and LensesGenerator #248), Task 11 (monthly activity)

2026-03-08 09:50 UTC — Run

• 💬 Commented on Duplicate Code: Structural Duplication in Generate Method Across DUCasesGenerator and FieldsGenerator #246: noted duplicate of Duplicate Code: Generate Method Structure in DUCasesGenerator and FieldsGenerator #240, pointed to PR MoiraeSoftwar...

• Fixes [Repo Assist] Monthly Activity 2026-03 #223

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

Consolidates duplicated DU-case identifier qualification logic (handling RequireQualifiedAccess) into GeneratorHelpers.resolveCaseIdent, and updates generators to use the shared helper to keep behavior consistent across plugins.

Changes:

• Added GeneratorHelpers.resolveCaseIdent to centralize DU case SynLongIdent construction.
• Updated DUCasesGenerator to remove the local helper and call GeneratorHelpers.resolveCaseIdent.
• Updated LensesGenerator to replace inline case-name construction with GeneratorHelpers.resolveCaseIdent.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/Myriad.Plugins/GeneratorHelpers.fs	Adds shared resolveCaseIdent helper for qualified DU case identifiers.
src/Myriad.Plugins/DUCasesGenerator.fs	Removes local duplication and switches call sites to the shared helper.
src/Myriad.Plugins/LensesGenerator.fs	Replaces inline RequireQualifiedAccess case-name logic with shared helper call.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.