Fix clipboard copy in Firefox#216
Open
Candypopppsss wants to merge 2 commits into
Open
Conversation
Author
|
Hi! I have submitted a fix for the Firefox clipboard |
|
Hey @Candypopppsss! Saw your work on GSSoC 2026. We are building TermUI, a TypeScript terminal UI framework with React-style hooks and JSX, rendered entirely in the terminal. We have 99 unassigned GSSoC issues open across widgets, hooks, adapters, and CLI tooling. Your JavaScript background transfers directly. Karanjot, TermUI maintainer |
Author
|
hi @Karanjot786 Thank you for your approach ! I'll look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the Copy Raw button silently failing in Firefox by adding a robust cross-browser clipboard implementation.
Root cause
navigator.clipboard.writeTextcan throwNotAllowedErrorin Firefox when the page doesn't have clipboard-write permission or the page isn't in active focus.Fix
navigator.clipboard.writeTextfirst (Chrome, Edge, modern FF)document.execCommand('copy')via a temporary textareaVisual Previews
Testing
Closes #216