Skip to content

Avoid warning of unused variable "offset" #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elral wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Avoid warning of unused variable "offset" #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62b735c
missing void for begin()
elral Oct 23, 2021
d572778
Merge branch 'Increase_Stability'
elral Oct 23, 2021
b6ae3bc
Merge branch 'Increase_Stability'
elral Oct 24, 2021
fd35a15
Merge branch 'MobiFlight:master' into master
elral Oct 28, 2021
6a231c7
Avoid warning of unused variable "offset"
elral Jan 11, 2022
c378081
B for binary format is depracated, use instead 0b
elral Jan 25, 2022
6879365
<avr/pgmspace.h> gets included by <Arduino.h>
elral Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/LedControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ void LedControl::setIntensity(int addr, int intensity) {
}

void LedControl::clearDisplay(int addr) {
int offset;

if(addr<0 || addr>=maxDevices)
return;
offset=addr*8;
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
int offset=addr*8;
#endif
for(int i=0;i<8;i++) {
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
status[offset+i]=0;
Expand All @@ -123,7 +123,7 @@ void LedControl::setLed(int addr, int row, int column, boolean state) {
if(row<0 || row>7 || column<0 || column>7)
return;
offset=addr*8;
val=B10000000 >> column;
val=0b10000000 >> column;
if(state)
status[offset+row]=status[offset+row]|val;
else {
Expand Down Expand Up @@ -160,40 +160,41 @@ void LedControl::setColumn(int addr, int col, byte value) {
#endif

void LedControl::setDigit(int addr, int digit, byte value, boolean dp) {
int offset;
byte v;

if(addr<0 || addr>=maxDevices)
return;
if(digit<0 || digit>7 || value>15)
return;
offset=addr*8;
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
int offset=addr*8;
#endif
byte v;
v=pgm_read_byte_near(charTable + value);
if(dp)
v|=B10000000;
v|=0b10000000;
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
status[offset+digit]=v;
#endif
spiTransfer(addr, digit+1,v);
}

void LedControl::setChar(int addr, int digit, char value, boolean dp) {
int offset;
byte index,v;

if(addr<0 || addr>=maxDevices)
return;
if(digit<0 || digit>7)
return;
offset=addr*8;
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
int offset=addr*8;
#endif
byte index,v;

index=(byte)value;
if(index >127) {
//nothing define we use the space char
value=32;
}
v=pgm_read_byte_near(charTable + index);
if(dp)
v|=B10000000;
v|=0b10000000;
#ifndef MF_REDUCE_FUNCT_LEDCONTROL
status[offset+digit]=v;
#endif
Expand Down
6 changes: 0 additions & 6 deletions src/LedControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@
#ifndef LedControl_h
#define LedControl_h

#include <avr/pgmspace.h>

#if (ARDUINO >= 100)
#include <Arduino.h>
#else
#include <WProgram.h>
#endif

/*
* Segments to be switched on for characters and digits on
Expand Down