This repository was archived by the owner on Mar 21, 2019. It is now read-only.
Adding focusable to generated <svg> tag based on props#28
Open
peasandwell wants to merge 1 commit intoMoOx:masterfrom
Open
Adding focusable to generated <svg> tag based on props#28peasandwell wants to merge 1 commit intoMoOx:masterfrom
peasandwell wants to merge 1 commit intoMoOx:masterfrom
Conversation
Owner
|
You can already handle that in your SVGs directly right? |
Author
|
I have the attribute on the SVG, however react-svg-inline doesn't pass it through to the DOM. I'll check out svgr too in case you deprecate this module. |
Owner
It the code too agressive here? https://github.com/MoOx/react-svg-inline/blob/master/src/index.js#L72 |
Author
I think that is what's happening, or maybe something else is either stripping it out or choosing not to consider it an attribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE11 has a fun bug where it treats all SVGs as tabbable elements, even if they have
tabindex="-1"on. The most recognised solution is to applyfocusable="false"onto the<svg>element.