refactor(room): 답안 제출 API 성능 개편 (Kafka 비동기 처리 & Redisson 분산 락 적용) - #72
Merged
Conversation
Develop to Main Ver.4
…g and Redisson lock
- Replace pessimistic DB lock (findByIdForUpdate) with Redisson distributed lock
- Add ROOM_SUBMIT_EVENTS topic to KafkaTopics
- Create RoomSubmitEventMessage DTO record with eventId idempotency key
- Implement RoomSubmitKafkaProducer in momogo-core for async event publishing
- Implement RoomSubmitKafkaConsumer in momogo-api with Redis deduplication
- Refactor RoomServiceImpl.submitRoomAnswer to delegate DB writes to Kafka
|
Warning Review limit reached
Next review available in: 42 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough답안 제출 처리를 동기 데이터베이스 작업에서 Kafka 기반 비동기 작업으로 변경했습니다. 제출 이벤트, 분산 락, Redis 멱등성 검사, 커밋 후 처리 완료 키 기록을 추가했습니다. Changes답안 제출 비동기 처리
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant RoomServiceImpl
participant RoomSubmitKafkaProducer
participant Kafka
participant RoomSubmitKafkaConsumer
participant Redis
participant Database
Client->>RoomServiceImpl: 답안 제출 요청
RoomServiceImpl->>RoomSubmitKafkaProducer: 제출 이벤트 전달
RoomSubmitKafkaProducer->>Kafka: room ID 키로 이벤트 발행
Kafka->>RoomSubmitKafkaConsumer: 제출 이벤트 전달
RoomSubmitKafkaConsumer->>Redis: 멱등성 키 확인
RoomSubmitKafkaConsumer->>Database: 답안 저장과 응시 완료 상태 갱신
Database-->>RoomSubmitKafkaConsumer: 트랜잭션 커밋 완료
RoomSubmitKafkaConsumer->>Redis: 처리 완료 키 기록
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (3)
momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java (1)
298-304: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value제안: 예외 코드 소속과 인터럽트 처리 메시지를 정리해 주세요.
두 가지 사항입니다.
AuthErrorCode.LOCK_ACQUISITION_FAILED(Line 299)는 인증 도메인 코드입니다. 답안 제출 락 실패는 방 도메인 관심사입니다.RoomErrorCode로 옮기거나 공용GlobalErrorCode에 두면 도메인 경계가 명확해집니다.InterruptedException처리(Line 301-303)에서 원인 예외를 버립니다. 로그에 원인을 남기면 장애 분석이 쉬워집니다.개념 참고: 에러 코드는 "어느 도메인이 이 실패를 소유하는가"를 기준으로 배치합니다. 호출 위치가 아니라 실패의 의미를 기준으로 삼습니다.
리뷰 근거: 경로 지침의 "서비스/도메인 설계, 공통 예외 처리를 확인" 항목에 따릅니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java` around lines 298 - 304, In the answer-submission lock timeout handling within RoomServiceImpl, replace the authentication-owned AuthErrorCode.LOCK_ACQUISITION_FAILED with an appropriate RoomErrorCode or shared GlobalErrorCode. In the InterruptedException catch, retain thread interruption and include the caught exception as the cause or in logging before throwing the internal-server error.Source: Path instructions
momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.java (1)
53-58: 🗄️ Data Integrity & Integration | 🔵 Trivial | 💤 Low value제안: 멱등성 검사를 원자적 연산으로 바꾸는 편이 안전합니다.
현재
hasKey조회와set기록이 분리되어 있습니다. 같은eventId가 서로 다른 컨슈머 스레드에 동시에 전달되면 두 스레드 모두 검사를 통과할 수 있습니다.
roomId를 파티션 키로 사용하므로 동일 파티션 내 순차 처리가 보장됩니다. 따라서 현재 위험은 낮습니다. 다만 파티션 재할당(rebalance) 직후 중복 전달 구간에서는 발생할 수 있습니다.개선 방법: 처리 시작 시점에
setIfAbsent로 "처리 중" 표시를 선점하고,afterCommit에서 TTL을 확정 값으로 갱신합니다. 롤백 시에는afterCompletion에서 키를 삭제해 재시도를 허용합니다.개념 참고: "검사 후 실행" 패턴은 분산 환경에서 원자성이 없습니다. Redis의
SETNX계열 연산이 검사와 기록을 한 번에 처리합니다.Line 82-88의
afterCommit사용은 좋은 선택입니다. DB 커밋 전에 멱등성 키를 기록하면 롤백 시 재처리가 막히기 때문입니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.java` around lines 53 - 58, RoomSubmitKafkaConsumer의 멱등성 처리에서 hasKey 기반 검사와 후속 기록을 setIfAbsent 원자적 선점으로 변경하세요. 처리 시작 시 dedupKey를 “처리 중” 상태로 등록하고, 선점에 실패하면 기존 중복 스킵 흐름을 유지하세요. 트랜잭션 커밋 후 afterCommit에서 키의 TTL을 확정 값으로 갱신하고, 롤백 또는 완료되지 않은 경우 afterCompletion에서 키를 삭제해 재시도가 가능하도록 하세요.momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.java (1)
19-19: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value제안:
KafkaTemplate제네릭 타입을 이벤트 타입으로 좁혀 주세요.현재
KafkaTemplate<String, Object>는 어떤 객체든 발행할 수 있습니다.KafkaTemplate<String, RoomSubmitEventMessage>로 좁히면 컴파일 시점에 잘못된 페이로드를 차단할 수 있습니다.다만 애플리케이션 컨텍스트에
KafkaTemplate<String, Object>빈 하나만 등록되어 있다면 타입 주입이 실패할 수 있습니다. 기존AiGradingProducer가 같은 빈을 공유하는지 먼저 확인해 주세요. 공유 구조라면 현재 형태를 유지하는 편이 낫습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.java` at line 19, Review RoomSubmitKafkaProducer and the existing AiGradingProducer bean wiring; if a dedicated KafkaTemplate<String, RoomSubmitEventMessage> can be injected safely, narrow the field type and preserve event-specific publishing, otherwise retain KafkaTemplate<String, Object> when both producers share the same application-context bean.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.java`:
- Around line 63-76: Validate every answer’s roomProblemId against the requested
room in RoomServiceImpl.submitRoomAnswer before publishing or processing the
message, rejecting IDs that are missing or belong to another room. Also retain
defensive validation in RoomSubmitKafkaConsumer around problemsById before
constructing UserRoomAnswer entries, and handle invalid messages as
non-retryable by logging and terminating or routing them to the DLT rather than
saving null or cross-room answers.
- Around line 78-80: Update the participant lookup in RoomSubmitKafkaConsumer so
a missing RoomUser does not silently continue after saving the answer:
explicitly fail the submission or log an error and handle the failure according
to the consumer’s existing error flow. Preserve RoomUser::attend for present
participants, and include roomId/userId context in any diagnostic log.
In
`@momogo-core/src/main/java/com/momogo/core/domain/room/event/RoomSubmitEventMessage.java`:
- Around line 17-22: Update the compact constructor of RoomSubmitEventMessage to
explicitly validate answers with Objects.requireNonNull using a Korean
field-specific message before copying it, and add equivalent null validation for
submittedAt. Keep the existing validation and List.copyOf immutability behavior
unchanged for the other fields.
In
`@momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.java`:
- Around line 21-32: 제출 파이프라인의 내구성 경계를 보강하세요.
momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.java
21-32의 RoomSubmitKafkaProducer.send()가 발행 결과를 나타내는 CompletableFuture를 반환하도록
변경하고, 호출자가 짧은 타임아웃으로 발행 확정을 기다리게 하세요.
momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.java
47-49의 RoomSubmitKafkaConsumer에는 DefaultErrorHandler와
DeadLetterPublishingRecoverer를 등록해 재시도 불가능한 소비 실패를 DLT에 보관하세요.
In
`@momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java`:
- Around line 261-300: Update the submission flow around the visible lock
acquisition and roomSubmitKafkaProducer.send call to atomically claim a Redis
marker keyed by roomId and userId while the lock is held, and only publish the
event when the claim succeeds; reject or treat subsequent claims as duplicate
submissions. Add the corresponding consumer-failure compensation to remove the
marker so failed processing can be retried, and retain database
unique-constraint handling in the consumer as the final duplicate safeguard.
- Around line 249-266: submitRoomAnswer에 `@Transactional`(propagation =
Propagation.NOT_SUPPORTED)를 지정해 클래스의 readOnly 트랜잭션이 락 대기 중 시작되지 않도록 변경하세요. 락 획득
후 수행하는 검증 조회와 답안 저장은 별도 트랜잭션 메서드 또는 컴포넌트로 분리해 기존 readOnly 검증과 쓰기 동작을 유지하세요.
---
Nitpick comments:
In
`@momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.java`:
- Around line 53-58: RoomSubmitKafkaConsumer의 멱등성 처리에서 hasKey 기반 검사와 후속 기록을
setIfAbsent 원자적 선점으로 변경하세요. 처리 시작 시 dedupKey를 “처리 중” 상태로 등록하고, 선점에 실패하면 기존 중복 스킵
흐름을 유지하세요. 트랜잭션 커밋 후 afterCommit에서 키의 TTL을 확정 값으로 갱신하고, 롤백 또는 완료되지 않은 경우
afterCompletion에서 키를 삭제해 재시도가 가능하도록 하세요.
In
`@momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.java`:
- Line 19: Review RoomSubmitKafkaProducer and the existing AiGradingProducer
bean wiring; if a dedicated KafkaTemplate<String, RoomSubmitEventMessage> can be
injected safely, narrow the field type and preserve event-specific publishing,
otherwise retain KafkaTemplate<String, Object> when both producers share the
same application-context bean.
In
`@momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java`:
- Around line 298-304: In the answer-submission lock timeout handling within
RoomServiceImpl, replace the authentication-owned
AuthErrorCode.LOCK_ACQUISITION_FAILED with an appropriate RoomErrorCode or
shared GlobalErrorCode. In the InterruptedException catch, retain thread
interruption and include the caught exception as the cause or in logging before
throwing the internal-server error.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f8b38573-7c08-43e9-9e9f-e0796faa8f83
📒 Files selected for processing (5)
momogo-api/src/main/java/com/momogo/api/room/consumer/RoomSubmitKafkaConsumer.javamomogo-core/src/main/java/com/momogo/core/common/config/KafkaTopics.javamomogo-core/src/main/java/com/momogo/core/domain/room/event/RoomSubmitEventMessage.javamomogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/RoomSubmitKafkaProducer.javamomogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java
…rocessing and Redisson lock
- Replace pessimistic DB lock with Redisson distributed lock outside DB transaction
- Prevent TOCTOU duplicate submissions using Redis claim markers (setIfAbsent)
- Enforce synchronous producer ACK wait with 3-second timeout for message durability
- Implement RoomSubmitKafkaConsumer with atomic Redis SETNX deduplication and rollback cleanup
- Validate problem room ownership and count synchronously in Service and Consumer
- Throw NOT_ROOM_PARTICIPANT exception on missing RoomUser during attendance update
- Add LOCK_ACQUISITION_FAILED error code to RoomErrorCode for domain boundary isolation
- Add non-null invariant checks to RoomSubmitEventMessage compact constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
변경 사항
1. momogo-core
2. momogo-api
체크리스트
참고 사항
관련 이슈
Summary by CodeRabbit