Skip to content

Develop to Main Ver.3 - #68

Merged
SungHuii merged 73 commits into
mainfrom
develop
Aug 10, 2026
Merged

Develop to Main Ver.3#68
SungHuii merged 73 commits into
mainfrom
develop

Conversation

@SungHuii

Copy link
Copy Markdown
Collaborator

작업 내용

Develop to Main Ver.3

변경 사항

체크리스트

  • 테스트 코드 작성 완료
  • 리뷰어 지정 완료

참고 사항

관련 이슈

Junkov0 and others added 30 commits July 31, 2026 15:29
feat: add Redis/Kafka boilerplate for distributed environment migration
…s-pubsub

Feat: impl STOMP Websocket Redis pub/sub message relay with DTO and constants
feat: configure AWS S3 storage integration and env properties
… Redis config

- Replace local Spring event with AiGradingProducer message publishing in RoomServiceImpl
- Convert AiGradingEventListener to @KafkaListener async consumer to eliminate CPU bottleneck and blocking
- Add KafkaTopics.AI_GRADING_EVENTS constant and AiGradingEventDto
- Explicitly declare LettuceConnectionFactory bean in RedisConfig to resolve Redisson StackOverflowError
- Add default environment placeholders in application.yaml and S3StorageService for local setup
…is config

- Re-throw exceptions in AiGradingEventListener to activate global Kafka retry & DLT policy
- Add immutable UUID eventId to AiGradingEventDto for message idempotency
- Add whenComplete callback in AiGradingProducer for async delivery tracking
- Bind Spring Boot RedisProperties in RedisConfig to support database/timeout properties
Junkov0 and others added 22 commits August 7, 2026 14:52
TTL 만료 후 다른 요청이 같은 키로 락을 재획득했을 때, 기존 요청의
실패 처리가 무조건 delete를 호출해 새 락을 지우는 문제가 있었음.
락 값을 요청별 토큰으로 바꾸고 Lua compare-and-delete로 소유자만
해제하도록 수정.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
catch(RuntimeException)만 처리해 성공 시 락이 TTL까지 남고,
Error 계열(OOM 등) 발생 시 락 누수가 있었음. finally로 바꿔
성공/실패/Error 모든 경로에서 락이 해제되도록 수정.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
feat: add Idempotency-Key guard to prevent duplicate AI problem generation
deleteRoomProblem read the room without acquiring a lock, then bulk-
updated problemOrder before deleting the target row. Concurrent
delete requests on the same room could race and leave problemOrder
with gaps or an inconsistent sequence, more likely across multiple
instances.

Switch to roomRepository.findByIdForUpdate, the same pessimistic-lock
pattern already used by createRoomProblemsByAi via
RoomProblemPersister#saveGeneratedProblems, so concurrent deletes on
the same room are serialized.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…m-problem creation

Both createCategory (name uniqueness) and createRoomProblem (problem
order uniqueness) only guarded against duplicates with a pre-check
(existsByName / relying on the DB constraint alone). Under concurrent
requests the pre-check can pass for both callers, leaving the DB
unique constraint as the only real guard, which surfaced as an
unmapped DataIntegrityViolationException instead of the intended
BusinessException.

Wrap the save in saveAndFlush + catch DataIntegrityViolationException,
matching the existing isDuplicateEmailViolation pattern in
UserServiceImpl: inspect getMostSpecificCause().getMessage() for the
constraint name and rethrow as a BusinessException, otherwise
propagate. Added RoomProblemErrorCode.DUPLICATE_PROBLEM_ORDER (7005);
reused the existing CATEGORY_NAME_DUPLICATED for categories.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix: lock room row before reordering on problem deletion
Feat: Setup Spring Boot Actuator with Prometheus and Grafana monitoring
… into feature/login-refactor

# Conflicts:
#	momogo-core/build.gradle
feat: impl BoundedBCryptPasswordEncoder and Redis cache configuration
…all spaces

Add force update/delete for spaces and full CRUD for problems that bypass
per-space ADMIN ownership checks, scoped to SUPER_ADMIN only.
…firm

Remove the mock interceptor for /api/super-admin/spaces and /problems so the
console hits the real API, paginate through all results, and drop the
now-stale demo-data banners. Add the notification bell to the space
problem-bank page, surface confirm failures as a toast instead of only
logging them, and filter already-confirmed notifications out of the list so
confirmed items don't reappear.
Connect the SSE stream first and only fetch GET /api/notifications after the
server's connect event is received, so notifications created between the
list fetch and the SSE connection are no longer lost. connectNotificationSse
now exposes the connect event's id via an onConnect callback.
feat: 슈퍼관리자 콘솔 백엔드 연동 및 알림 확인 버그 수정
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@SungHuii, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a3d40e4a-9fed-4fba-9373-5a7bf6c4beb9

📥 Commits

Reviewing files that changed from the base of the PR and between c5683b7 and 3730755.

📒 Files selected for processing (94)
  • .github/workflows/deploy-production.yml
  • db/schema.sql
  • docker-compose.yml
  • k6/problem-ai/config.js
  • k6/problem-ai/load-result.json
  • k6/problem-ai/soak-result.json
  • k6/problem-ai/spike-result.json
  • k6/problem-ai/stress-result.json
  • momogo-ai/src/main/java/com/momogo/ai/grading/listener/AiGradingEventListener.java
  • momogo-api/src/main/java/com/momogo/api/MomogoApiApplication.java
  • momogo-api/src/main/java/com/momogo/api/auth/config/SecurityConfig.java
  • momogo-api/src/main/java/com/momogo/api/auth/details/MoMoGoUserDetails.java
  • momogo-api/src/main/java/com/momogo/api/auth/details/MoMoGoUserDetailsService.java
  • momogo-api/src/main/java/com/momogo/api/auth/details/OAuth2UserDetailsService.java
  • momogo-api/src/main/java/com/momogo/api/auth/handler/LoginFailureHandler.java
  • momogo-api/src/main/java/com/momogo/api/auth/jwt/InMemoryJwtRegistry.java
  • momogo-api/src/main/java/com/momogo/api/auth/jwt/JwtAuthenticationFilter.java
  • momogo-api/src/main/java/com/momogo/api/auth/jwt/RedisJwtRegistry.java
  • momogo-api/src/main/java/com/momogo/api/auth/listener/UserSessionEventListener.java
  • momogo-api/src/main/java/com/momogo/api/auth/security/BoundedBCryptPasswordEncoder.java
  • momogo-api/src/main/java/com/momogo/api/common/config/CacheConfig.java
  • momogo-api/src/main/java/com/momogo/api/notification/consumer/NotificationKafkaConsumer.java
  • momogo-api/src/main/java/com/momogo/api/notification/event/NotificationsPersistedEvent.java
  • momogo-api/src/main/java/com/momogo/api/notification/listener/NotificationSsePublishListener.java
  • momogo-api/src/main/java/com/momogo/api/notification/redis/NotificationRedisExecutorConfig.java
  • momogo-api/src/main/java/com/momogo/api/notification/redis/NotificationRedisPubSubConfig.java
  • momogo-api/src/main/java/com/momogo/api/notification/redis/NotificationRedisSubscriber.java
  • momogo-api/src/main/java/com/momogo/api/notification/redis/NotificationSseMessage.java
  • momogo-api/src/main/java/com/momogo/api/notification/registry/NotificationEmitterRegistry.java
  • momogo-api/src/main/java/com/momogo/api/notification/scheduler/NotificationSseHeartbeatScheduler.java
  • momogo-api/src/main/java/com/momogo/api/notification/service/NotificationSseServiceImpl.java
  • momogo-api/src/main/java/com/momogo/api/problem/ProblemController.java
  • momogo-api/src/main/java/com/momogo/api/room/RoomProblemController.java
  • momogo-api/src/main/java/com/momogo/api/superadmin/SuperAdminController.java
  • momogo-api/src/main/resources/application.yaml
  • momogo-batch/build.gradle
  • momogo-batch/src/main/java/com/momogo/batch/config/ShedLockConfig.java
  • momogo-batch/src/main/java/com/momogo/batch/scheduler/BatchScheduler.java
  • momogo-batch/src/main/java/com/momogo/batch/scheduler/ExpiredUserCleanupScheduler.java
  • momogo-batch/src/main/resources/application.yaml
  • momogo-core/build.gradle
  • momogo-core/src/main/java/com/momogo/core/common/config/AsyncConfig.java
  • momogo-core/src/main/java/com/momogo/core/common/config/KafkaConfig.java
  • momogo-core/src/main/java/com/momogo/core/common/config/KafkaTopics.java
  • momogo-core/src/main/java/com/momogo/core/common/config/RedisConfig.java
  • momogo-core/src/main/java/com/momogo/core/common/exception/AuthErrorCode.java
  • momogo-core/src/main/java/com/momogo/core/common/exception/BusinessException.java
  • momogo-core/src/main/java/com/momogo/core/common/exception/GlobalErrorCode.java
  • momogo-core/src/main/java/com/momogo/core/common/exception/RealtimeErrorCode.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/LocalStorageService.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/S3StorageService.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/StorageService.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/event/FileDeleteEvent.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/event/FileRollbackDeleteEvent.java
  • momogo-core/src/main/java/com/momogo/core/common/storage/listener/FileDeleteEventListener.java
  • momogo-core/src/main/java/com/momogo/core/common/util/ImageFileValidator.java
  • momogo-core/src/main/java/com/momogo/core/common/util/storage/ImageProcessor.java
  • momogo-core/src/main/java/com/momogo/core/common/util/storage/ImageResizeSpec.java
  • momogo-core/src/main/java/com/momogo/core/common/util/storage/StorageDirectoryValidator.java
  • momogo-core/src/main/java/com/momogo/core/domain/notification/event/NotificationEventMessage.java
  • momogo-core/src/main/java/com/momogo/core/domain/notification/event/NotificationKafkaProducer.java
  • momogo-core/src/main/java/com/momogo/core/domain/notification/listener/NotificationEventListener.java
  • momogo-core/src/main/java/com/momogo/core/domain/problem/exception/ProblemErrorCode.java
  • momogo-core/src/main/java/com/momogo/core/domain/problem/repository/ProblemRepository.java
  • momogo-core/src/main/java/com/momogo/core/domain/problem/service/ProblemCategoryServiceImpl.java
  • momogo-core/src/main/java/com/momogo/core/domain/problem/service/ProblemService.java
  • momogo-core/src/main/java/com/momogo/core/domain/problem/service/ProblemServiceImpl.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/dto/event/AiGradingEventDto.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/entity/UserRoomAnswer.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/exception/RoomProblemErrorCode.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/kafka/producer/AiGradingProducer.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/repository/UserRoomAnswerRepository.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomProblemService.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomProblemServiceImpl.java
  • momogo-core/src/main/java/com/momogo/core/domain/room/service/RoomServiceImpl.java
  • momogo-core/src/main/java/com/momogo/core/domain/space/service/SpaceService.java
  • momogo-core/src/main/java/com/momogo/core/domain/space/service/SpaceServiceImpl.java
  • momogo-core/src/main/java/com/momogo/core/domain/user/event/UserCacheEvictEvent.java
  • momogo-core/src/main/java/com/momogo/core/domain/user/service/UserCacheService.java
  • momogo-core/src/main/java/com/momogo/core/domain/user/service/UserHardDeleteProcessor.java
  • momogo-core/src/main/java/com/momogo/core/domain/user/service/UserServiceImpl.java
  • momogo-frontend/src/pages/DashboardPage.tsx
  • momogo-frontend/src/pages/SpacePage.tsx
  • momogo-frontend/src/services/api.ts
  • momogo-realtime/src/main/java/com/momogo/realtime/config/RedisPubSubConfig.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/constant/WebSocketConstants.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/controller/RoomRealtimeController.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/dto/request/RealtimeMessageRequest.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/dto/response/RealtimeMessageResponse.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/dto/type/RoomRealtimeStatus.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/redis/RedisMessagePublisher.java
  • momogo-realtime/src/main/java/com/momogo/realtime/websocket/redis/RedisMessageSubscriber.java
  • momogo-realtime/src/main/resources/application.yaml
  • prometheus/prometheus.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jaejo jaejo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@idktomorrow idktomorrow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3차배포 고생하셨습니다 👍

@SungHuii
SungHuii merged commit 05a230f into main Aug 10, 2026
2 checks passed

@Junkov0 Junkov0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants