Add URL extraction utility with tests and enable clang-tidy check profiling#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
clang-tidycheck profile for later inspection.Description
include/a2a/core/url_utils.hwhich implementsExtractTargetPathandUrlSuffixPolicyto normalize URL targets and preserve optional query/fragment suffixes.examples/example_support.hto usecore::ExtractTargetPathinstead of the previous localUrlToTargetimplementation.tests/unit/url_utils_test.cppand registerurl_utils_testintests/CMakeLists.txt, and updatetests/unit/examples_support_test.cppto reflect normalized behavior.scripts/run_clang_tidy.shto enable--enable-check-profileand write the profile to${CLANG_TIDY_CHECK_PROFILE_FILE}(default under the build dir).Testing
url_utils_testwhich verifies absolute URLs, no-scheme inputs, suffix policies, and default-path behavior, and it succeeded.examples_support_testwhich validates the normalized target extraction and executor flows, and it succeeded.gtest_discover_tests) and all tests passed; additionallyscripts/run_clang_tidy.shwas executed and successfully produced a clang-tidy check profile file.Codex Task