-
Notifications
You must be signed in to change notification settings - Fork 57
fix: 修正 MXU_WEBHOOK_ACTION 的 HTTP 請求處理 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+126
−14
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): 使用
json(&value)可能会覆盖用户提供的Content-Type头。对于非字符串的请求体,
request.json(&value)总是会设置Content-Type: application/json,这会覆盖在headers中设置的任何头。如果调用方必须控制内容类型,建议通过request.body(serde_json::to_vec(&value)?/to_string())手动序列化,以保留他们设置的头,或者仅在尚未设置Content-Type时才使用json()。Original comment in English
issue (bug_risk): Using
json(&value)may override user-providedContent-Typeheaders.For non-string bodies,
request.json(&value)always setsContent-Type: application/json, which will override any header set inheaders. If callers must control the content type, consider serializing manually viarequest.body(serde_json::to_vec(&value)?/to_string())so their header is preserved, or only usejson()whenContent-Typeis not already present.