-
Notifications
You must be signed in to change notification settings - Fork 58
feat: 支持导出配置为文件和导入 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: 支持导出配置为文件和导入 #244
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): 分隔符菜单项仍然被渲染为可交互按钮,而不是仅作为视觉分隔符。
MenuItemComponent将所有条目都视为可点击项,但MenuItem是支持divider条目的(可参考在生成 key 时对divider的检查)。这些divider条目目前会被渲染为空的、可点击的行。请在处理
hasChildren/handleClick逻辑之前为divider条目添加一个提前返回,例如:对子级条目也应用同样的处理,以便嵌套的分隔符也被渲染为不可交互的分隔线。
Original comment in English
issue (bug_risk): Divider menu items are still rendered as interactive buttons instead of visual separators.
MenuItemComponenttreats all items as clickable, butMenuItemsupportsdivideritems (see thedividerchecks when generating keys). These divider items are currently rendered as empty, clickable rows.Add an early return for divider items (before
hasChildren/handleClick), e.g.:Apply the same handling for child items so nested dividers are rendered as non-interactive separators as well.