fix: Kill child npm/ng processes when host process exits#74
Merged
Conversation
When stopping the VS debugger, the .NET host is terminated abruptly so IHostApplicationLifetime.ApplicationStopping never fires and the npm/ng serve child processes become orphaned. Add ProcessTracker that uses a Windows Job Object with JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE so the OS kills children when the parent handle closes, even on abrupt termination. Also registers an AppDomain.ProcessExit handler as a cross-platform fallback for graceful shutdowns. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IHostApplicationLifetime.ApplicationStoppingnever fires and thenpm start/ng servechild processes become orphaned (ports remain occupied)ProcessTrackerthat uses a Windows Job Object withJOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSEso the OS automatically kills child processes when the parent handle closes — even on abrupt terminationAppDomain.ProcessExithandler as a cross-platform fallback for graceful shutdownsTest plan
ng serveprocesses start and ports are accessibleng serveprocesses are killed and ports are releaseddotnet run+ Ctrl+C still cleans up properly🤖 Generated with Claude Code