fix(spacing): symmetric internal padding in Dialog, Card, Tour, confirm-popover - #26
Merged
Conversation
…rm-popover Dialog and Card's body→footer gap was silently double-counted against header→body (both the preceding and following section added padding for the same transition instead of one owning it), making it exactly double. Tour had the same double-count on its description→actions gap, plus its own header/actions padding was stacking on top of Popover's shared body padding, doubling the outer margin. confirmAction's popover surface had no edge padding of its own (all from Popover's shared 1rem) with interior gaps too tight relative to it. All four now use one consistent 2:1 edge-to-interior ratio, single-owner gaps on every transition.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ui-popover-bodypadding (1rem), doubling the outer margin (2rem effective edge vs 0.5rem interior — a ~4:1 ratio). Zeroed Popover's body padding specifically when it wraps Tour content, so Tour's own padding is the single source of outer spacing.shared/confirm-popover.css) had no edge padding of its own — all of it came from Popover's shared 1rem — with interior gaps too tight relative to that (previously 0.35rem/0.6rem asymmetric, briefly over-corrected to a too-tight uniform 0.25rem). Now 0.5rem, matching the same 2:1 edge-to-interior ratio Tour uses in the same Popover body.All four now follow one consistent, deliberate 2:1 edge-to-interior ratio, with every transition owned by exactly one side.
Verification
pnpm build,pnpm typecheck:only, andpnpm --filter vael-ui test(691/691) all pass clean from a from-scratch rebuild.Test plan
pnpm build(root) — cleanpnpm typecheck:only— cleanpnpm --filter vael-ui test— 691/691 passed