Address static surface cleanup review - #18
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR applies the remaining “static surface” cleanup from PR #16 onto the current alpha-pre branch by removing unnecessary Redux connect(state => state) wrappers from the static About and Index components and tidying up related imports/comments.
Changes:
- Removed
connect(state => state)wrapping fromsrc/components/About.tsxandsrc/components/Index.tsx. - Removed now-unused imports in
src/components/Index.tsx. - Corrected the stale file header comment in
src/components/About.tsx.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/Index.tsx |
Drops unused imports and removes the Redux connect(state => state) wrapper from the exported component. |
src/components/About.tsx |
Fixes the header comment and removes the Redux connect(state => state) wrapper from the exported component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #16. PR #16 was merged before the review cleanup commit landed on its branch, so this PR carries that cleanup onto current
alpha-pre.Changes
connect(state => state)wrappers from staticAboutandIndexcomponents.About.tsxfile header comment.Validation
npm run buildnpm test