Conversation
fix: dynamic date filter handling in Transaction model and requests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how dynamic date filters are handled for transactions, simplifying the controller logic and moving filter type handling into the request validation layer. The changes ensure that filter types (
before,after,between) are consistently prepended to filter values, and the model’s scope method is updated to expect this new format.Dynamic Date Filter Handling Improvements:
before,after,between) to filter values from the controller to theIndexTransactionsRequestby implementing a newpassedValidationmethod. This ensures filters are consistently formatted before reaching the model.scopeDynamicDateFiltermethod in theTransactionmodel to expect the filter type as the first parameter in the value string, adjusting parameter extraction accordingly. [1] [2]Controller Filter Configuration Simplification:
indexandindexDeletedmethods, as the filter type is now handled in the request. [1] [2]