ci: use client-id for create-github-app-token#52
Merged
Conversation
create-github-app-token@v3 deprecated the app-id input in favor of client-id. Switch to client-id, backed by a new MILLIPRESS_BOT_CLIENT_ID secret (the bot app's Client ID, distinct from its numeric App ID).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the deprecation warning from the asset-build job:
actions/create-github-app-token@v3deprecatedapp-idin favor ofclient-id. This switches the input.The Client ID is a different value from the numeric App ID, so the existing
MILLIPRESS_BOT_APP_IDsecret can't be reused. Add aMILLIPRESS_BOT_CLIENT_IDsecret (org-level, matching the otherMILLIPRESS_BOT_*secrets) holding the bot app's Client ID — found at Settings → Developer settings → GitHub Apps → [the bot app] → Client ID (formatIv23li…).If this merges before that secret exists, the push-time "Build & Commit Assets" step will fail (empty
client-id). The Client ID isn't sensitive, so an Actions variable (vars.MILLIPRESS_BOT_CLIENT_ID) would also work if you'd prefer that over a secret — say the word and I'll switch it.Verified against the action README (v3.2.0):
client-idis recommended;app-idstill works but is deprecated.