Update invoke shared auth source path#4
Merged
Conversation
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@invoke.ps1`:
- Line 11: The script currently hard-codes $SharedSrc to a machine-specific
absolute path; change $SharedSrc to be configurable (read from a script
parameter or environment variable, e.g., $env:SHARED_SRC or a Param() default)
and if not provided fall back to a repository-relative path (e.g., ../src or
./src), then resolve to an absolute path with Resolve-Path and validate with
Test-Path before using it to build PYTHONPATH; if the path is invalid, stop the
script with a clear error message so PYTHONPATH is not polluted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@invoke.ps1`:
- Around line 15-16: The current check uses Test-Path which returns true for
files too; change the conditional that validates $SharedSrc (the if block
guarding the Write-Error message) to ensure $SharedSrc is an existing directory
by using Test-Path with PathType 'Container' (or equivalent directory check) so
only directories get accepted and files are rejected before appending to
PYTHONPATH.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: plain global python -m pytest is not usable in this checkout because the global interpreter is missing project deps/import path.
Need help on this PR? Tag
@codesmithwith what you need.Summary by CodeRabbit