Show why ruleset crash checks failed#23
Merged
Merged
Conversation
relh
changed the title
Co-authored-by: Codex GPT-5 <codex@openai.com>
relh
force-pushed
the
relh/ruleset-crash-check-failure-evidence
branch
from
9ec4a74 to
149d91e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruleset round completion could say that crash checks failed without carrying enough evidence about what actually failed. That made the transition hard to debug from the round result alone.
This PR carries failed episode messages from the websocket into ruleset round completion. It also adds scheduled and failed episode counts, failed request ids, and sampled errors to the transition evidence. The docker smoke assertion is relaxed so bundled configs with multi-episode stages still pass the smoke invariant.
Verification
uv run pytest tests/test_commissioner_strategies.py tests/test_commissioner_websocket.py -quv run pytest -quv run ruff check commissioners/common/models.py commissioners/common/adapters.py commissioners/common/server.py commissioners/common/ruleset_strategy/commissioner.py commissioners/common/ruleset_strategy/round_start.py commissioners/common/ruleset_strategy/membership_events.py tests/test_commissioner_strategies.py tests/test_commissioner_websocket.py tests/test_docker_smoke.pygit diff --check