Skip to content

Implement server-side timeout setting via environment variable#3

Merged
SimonSimCity merged 2 commits into
Meteor-Community-Packages:masterfrom
hexsprite:master
Nov 21, 2018
Merged

Implement server-side timeout setting via environment variable#3
SimonSimCity merged 2 commits into
Meteor-Community-Packages:masterfrom
hexsprite:master

Conversation

@hexsprite

Copy link
Copy Markdown

No description provided.

@hexsprite

Copy link
Copy Markdown
Author

Just realized I forgot to create the PR! :)

@SimonSimCity

Copy link
Copy Markdown
Member

Thanks for taking the time of creating this PR. I'd like to merge this soon as well.

Please check if you'd not also get it working on the client side. This PR claims to also allow setting the timeout for the client: practicalmeteor#9

@hexsprite

Copy link
Copy Markdown
Author

@SimonSimCity it's not an itch I have at the moment and I can't spare any time to get it working on client side. As it, this does solve the server-side issue, so perhaps we can merge this and also work towards getting it working on client side when someone has the time?

@SimonSimCity
SimonSimCity merged commit f87fa4d into Meteor-Community-Packages:master Nov 21, 2018
@SimonSimCity

Copy link
Copy Markdown
Member

@hexsprite thanks for providing the PR here. I've found some time yesterday to finish this up and test it through. The changes I've added to yours are visible here: d1cd5df

The major changes I did was renaming the environment variable to MOCHA_TIMEOUT which will set this timeout for the server and the client - it mainly was a code-copy of practicalmeteor#9.

@hexsprite

Copy link
Copy Markdown
Author

@SimonSimCity oh nice, that was a handy way of using Meteor.settings to pass data from server to client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants