This repository was archived by the owner on Feb 27, 2020. It is now read-only.
Conversation
Contributor
There was a problem hiding this comment.
Keep the default - otherwise this will cause bugs if people use it and our stable version has features which the Juju charm hasn't been updated to account for.
Contributor
|
Couple of comments - basically about ensuring these charms still work even if release-100 (say) has a slightly different install process. |
Contributor
Author
|
Code-review mark-ups applied - pending other merges (e.g. DNS) before we merge this. |
forward port support for dns-json format to use last dns charm.
[Reviewer: Rob] Add 3GPP-Cx interface to HSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rob,
Please can you review these changes to move up to using Ubuntu Trusty and the latest Clearwater? The big changes here are
/etc/clearwater/local_configand/etc/clearwater/shared_configbecause the latest Clearwater requires itI don't intend to merge these yet. Nicolas Thomas from Canonical is testing with them, and has some further fixes he'd like to merge.
Thanks,
Matt