initial node health tool commit#368
Conversation
|
@rkd-msw Ross is leaving tomorrow, and it would be good to get this merged before he leaves. Can you please take a look and see if that's reasonable? Can you also figure out whether it's going to be possible for him to upgrade Python himself? If it's simple, he might as well. |
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"; | |||
There was a problem hiding this comment.
Could you move health_tool_source into another directory (/usr/share/clearwater/health_tool?) and have this script just call /usr/share/clearwater/health_tool/run.py?
|
I've taken a quick look - apart from one comment about directory locations, I don't see anything that means you shouldn't merge this now. For installing Python 3.4, you just want to add it to https://github.com/Metaswitch/clearwater-infrastructure/blob/master/debian/control#L14 (note that you should leave the python 2.7 entry - we want both 2.7 and 3.4 installed). (I'm expecting that I or someone else will do a more thorough review in the next few weeks - Chris tells me that @Tom-Rees is already expecting to have some time to apply markups from that review.) |
|
Did I? I haven't talked to Tom about this, so I expect he's not expecting it. @rkd-msw: are you happy to talk to him? |
|
Think I've made the changes, @rkd-msw can you double check that I've added the python dependency correctly please? Sorry about the last minute dash guys! |
|
The package is called @steelyvoid - you pointed out that this calls clearwater-status for information, which doesn't exist on Project Clearwater systems. You were going to check whether the Project Clearwater testing done was right - assigning to you as you have the next action here. |
4 participants
This is the first commit of the node health tool, it is a command line tool which uses the python curses library for it's UI. At this minute, PC doesn't have Python 3.4.3 but the tool is dependent on this - Rob has said it should be fine to upgrade the python 3 version on PC but I'm not sure how you would go about this.
can you review, handle the python upgrade and merge please? I've assigned this to you as you know the most about the tool currently.